Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2094023002: Use a union inside GrShape to hold geometry (Closed)

Created:
4 years, 6 months ago by bsalomon
Modified:
4 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@noprkey
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : more #

Patch Set 3 : more #

Patch Set 4 : Don't use anonymous structs in union #

Patch Set 5 : line wrap #

Patch Set 6 : cleanup #

Patch Set 7 : move comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -182 lines) Patch
M src/gpu/GrShape.h View 1 2 3 4 5 6 10 chunks +108 lines, -87 lines 0 comments Download
M src/gpu/GrShape.cpp View 1 2 3 4 5 16 chunks +92 lines, -95 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
bsalomon
4 years, 5 months ago (2016-06-27 16:03:41 UTC) #3
robertphillips
lgtm
4 years, 5 months ago (2016-06-27 16:26:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2094023002/120001
4 years, 5 months ago (2016-06-27 16:38:25 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 17:00:23 UTC) #8
Message was sent while issue was closed. 
Committed patchset #7 (id:120001) as
https://skia.googlesource.com/skia/+/728b0f750570ada198bde4c5b4605bc1902de1d4

Powered by Google App Engine
This is Rietveld 408576698