Issue 2064743003: Remove floats from LayoutView in removeFloatingOrPositionedChildFromBlockLists

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2064743003: Remove floats from LayoutView in removeFloatingOrPositionedChildFromBlockLists (Closed)

Created:
4 years, 6 months ago by kojii

Modified:
4 years, 6 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2743

Target Ref:
refs/pending/branch-heads/2743

Project:
chromium

Visibility:
Public.

Remove floats from LayoutView in removeFloatingOrPositionedChildFromBlockLists This patch fixes removeFloatingOrPositionedChildFromBlockLists fails to remove floats when their containing block is LayoutView. BUG=613869 Review-Url: https://codereview.chromium.org/2042353002 Cr-Commit-Position: refs/heads/master@{#398399} (cherry picked from commit fac93418b4bcf2f8c7480696567db3e2d12d467b) Committed: https://chromium.googlesource.com/chromium/src/+/db32c89564e79897cb949d6d8fb714c5068341f9

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -1 line)			Patch
A	third_party/WebKit/LayoutTests/fast/writing-mode/orthogonal-writing-modes-in-layoutview-with-floats.html	View	1 chunk	+16 lines, -0 lines	0 comments	Download
A	third_party/WebKit/LayoutTests/fast/writing-mode/orthogonal-writing-modes-in-layoutview-with-floats-expected.txt	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/layout/LayoutBox.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (1 generated)

kojii

4 years, 6 months ago (2016-06-14 07:38:18 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
db32c89564e79897cb949d6d8fb714c5068341f9.