Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2042353002: Remove floats from LayoutView in removeFloatingOrPositionedChildFromBlockLists (Closed)

Created:
4 years, 6 months ago by kojii
Modified:
4 years, 6 months ago
Reviewers:
eae
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove floats from LayoutView in removeFloatingOrPositionedChildFromBlockLists This patch fixes removeFloatingOrPositionedChildFromBlockLists fails to remove floats when their containing block is LayoutView. BUG=613869 Committed: https://crrev.com/fac93418b4bcf2f8c7480696567db3e2d12d467b Cr-Commit-Position: refs/heads/master@{#398399}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/writing-mode/orthogonal-writing-modes-in-layoutview-with-floats.html View 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/writing-mode/orthogonal-writing-modes-in-layoutview-with-floats-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
kojii
PTAL.
4 years, 6 months ago (2016-06-07 18:56:42 UTC) #6
eae
Nice, LGTM
4 years, 6 months ago (2016-06-07 20:50:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2042353002/20001
4 years, 6 months ago (2016-06-07 21:03:04 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 6 months ago (2016-06-07 22:20:03 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 22:20:59 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/fac93418b4bcf2f8c7480696567db3e2d12d467b
Cr-Commit-Position: refs/heads/master@{#398399}

Powered by Google App Engine
This is Rietveld 408576698