Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 206453010: NavigationAction should not retain Event. (Closed)

Created:
6 years, 9 months ago by kouhei (in TOK)
Modified:
6 years, 9 months ago
CC:
blink-reviews, gavinp+loader_chromium.org
Visibility:
Public.

Description

NavigationAction should not retain Event. NavigationAction class before this patch had a RefPtr<Event> as its member. The event retained the previous document longer than necessary, resulting in a soft leak. This patch removes the member from the NavigationAction class and replaces it with DOMTimeStamp of the event which is the only information may be retrieved afterward. BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169753

Patch Set 1 #

Patch Set 2 : add missing init #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -33 lines) Patch
A LayoutTests/fast/dom/document-softleak-mouse-navigation.html View 1 chunk +34 lines, -0 lines 0 comments Download
A + LayoutTests/fast/dom/document-softleak-mouse-navigation-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A LayoutTests/fast/dom/resources/link.html View 1 chunk +6 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/resources/notify-parent.html View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/resources/leak-check.js View 2 chunks +21 lines, -21 lines 0 comments Download
M Source/core/loader/NavigationAction.h View 2 chunks +3 lines, -2 lines 0 comments Download
M Source/core/loader/NavigationAction.cpp View 1 1 chunk +12 lines, -7 lines 0 comments Download
M Source/web/WebDataSourceImpl.cpp View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
kouhei (in TOK)
Would you take a look?
6 years, 9 months ago (2014-03-21 11:41:04 UTC) #1
haraken
LGTM
6 years, 9 months ago (2014-03-21 11:49:24 UTC) #2
kouhei (in TOK)
+japhet
6 years, 9 months ago (2014-03-21 11:56:34 UTC) #3
Nate Chapin
On 2014/03/21 11:56:34, kouhei wrote: > +japhet LGTM
6 years, 9 months ago (2014-03-21 16:21:16 UTC) #4
kouhei (in TOK)
Thanks for review!
6 years, 9 months ago (2014-03-21 16:22:00 UTC) #5
kouhei (in TOK)
The CQ bit was checked by kouhei@chromium.org
6 years, 9 months ago (2014-03-21 16:22:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/206453010/20001
6 years, 9 months ago (2014-03-21 16:22:13 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-21 16:23:24 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
6 years, 9 months ago (2014-03-21 16:23:25 UTC) #9
kouhei (in TOK)
The CQ bit was checked by kouhei@chromium.org
6 years, 9 months ago (2014-03-21 16:31:08 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/206453010/20001
6 years, 9 months ago (2014-03-21 16:31:13 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-21 16:53:48 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 9 months ago (2014-03-21 16:53:49 UTC) #13
kouhei (in TOK)
The CQ bit was checked by kouhei@chromium.org
6 years, 9 months ago (2014-03-21 16:55:08 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/206453010/20001
6 years, 9 months ago (2014-03-21 16:55:17 UTC) #15
kouhei (in TOK)
The CQ bit was unchecked by kouhei@chromium.org
6 years, 9 months ago (2014-03-21 16:55:22 UTC) #16
kouhei (in TOK)
The CQ bit was checked by kouhei@chromium.org
6 years, 9 months ago (2014-03-21 17:01:12 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/206453010/40001
6 years, 9 months ago (2014-03-21 17:01:17 UTC) #18
commit-bot: I haz the power
6 years, 9 months ago (2014-03-21 18:01:24 UTC) #19
Message was sent while issue was closed.
Change committed as 169753

Powered by Google App Engine
This is Rietveld 408576698