Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Side by Side Diff: Source/core/loader/NavigationAction.h

Issue 206453010: NavigationAction should not retain Event. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « LayoutTests/resources/leak-check.js ('k') | Source/core/loader/NavigationAction.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006 Apple Computer, Inc. All rights reserved. 2 * Copyright (C) 2006 Apple Computer, Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 11 matching lines...) Expand all
22 * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; 22 * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
23 * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND 23 * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
24 * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 24 * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF 25 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
26 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 */ 27 */
28 28
29 #ifndef NavigationAction_h 29 #ifndef NavigationAction_h
30 #define NavigationAction_h 30 #define NavigationAction_h
31 31
32 #include "core/dom/DOMTimeStamp.h"
32 #include "core/events/Event.h" 33 #include "core/events/Event.h"
33 #include "core/loader/FrameLoaderTypes.h" 34 #include "core/loader/FrameLoaderTypes.h"
34 #include "core/loader/NavigationPolicy.h" 35 #include "core/loader/NavigationPolicy.h"
35 #include "platform/network/ResourceRequest.h" 36 #include "platform/network/ResourceRequest.h"
36 #include "platform/weborigin/KURL.h" 37 #include "platform/weborigin/KURL.h"
37 #include "wtf/Forward.h" 38 #include "wtf/Forward.h"
38 39
39 namespace WebCore { 40 namespace WebCore {
40 41
41 class NavigationAction { 42 class NavigationAction {
42 public: 43 public:
43 NavigationAction(); 44 NavigationAction();
44 NavigationAction(const ResourceRequest&, FrameLoadType = FrameLoadTypeSt andard, bool isFormSubmission = false, PassRefPtr<Event> = nullptr); 45 NavigationAction(const ResourceRequest&, FrameLoadType = FrameLoadTypeSt andard, bool isFormSubmission = false, PassRefPtr<Event> = nullptr);
45 46
46 const ResourceRequest& resourceRequest() const { return m_resourceReques t; } 47 const ResourceRequest& resourceRequest() const { return m_resourceReques t; }
47 NavigationType type() const { return m_type; } 48 NavigationType type() const { return m_type; }
48 Event* event() const { return m_event.get(); } 49 DOMTimeStamp eventTimeStamp() const { return m_eventTimeStamp; }
49 NavigationPolicy policy() const { return m_policy; } 50 NavigationPolicy policy() const { return m_policy; }
50 bool shouldOpenInNewWindow() const { return m_policy != NavigationPolicy CurrentTab; } 51 bool shouldOpenInNewWindow() const { return m_policy != NavigationPolicy CurrentTab; }
51 52
52 private: 53 private:
53 ResourceRequest m_resourceRequest; 54 ResourceRequest m_resourceRequest;
54 NavigationType m_type; 55 NavigationType m_type;
55 RefPtr<Event> m_event; 56 DOMTimeStamp m_eventTimeStamp;
56 NavigationPolicy m_policy; 57 NavigationPolicy m_policy;
57 }; 58 };
58 59
59 } 60 }
60 61
61 #endif 62 #endif
OLDNEW
« no previous file with comments | « LayoutTests/resources/leak-check.js ('k') | Source/core/loader/NavigationAction.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698