Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: net/ssl/server_bound_cert_service_unittest.cc

Issue 206453002: Introduce USE_OPENSSL_CERTS for certificate handling. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changed meaning of USE_OPENSSL_CERTS Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/ssl/server_bound_cert_service_unittest.cc
diff --git a/net/ssl/server_bound_cert_service_unittest.cc b/net/ssl/server_bound_cert_service_unittest.cc
index 4df003913aa0b74d96558ca05d8a6d5de9e069b6..cef737810f6d5ceacebd2cd52ffea3d1d2aee7e2 100644
--- a/net/ssl/server_bound_cert_service_unittest.cc
+++ b/net/ssl/server_bound_cert_service_unittest.cc
@@ -24,7 +24,6 @@ namespace net {
namespace {
-#if !defined(USE_OPENSSL)
void FailTest(int /* result */) {
FAIL();
}
@@ -117,8 +116,6 @@ MockServerBoundCertStoreWithAsyncGet::CallGetServerBoundCertCallbackWithResult(
cert));
}
-#endif // !defined(USE_OPENSSL)
-
class ServerBoundCertServiceTest : public testing::Test {
public:
ServerBoundCertServiceTest()
@@ -150,9 +147,6 @@ TEST_F(ServerBoundCertServiceTest, GetDomainForHost) {
ServerBoundCertService::GetDomainForHost("127.0.0.1"));
}
-// See http://crbug.com/91512 - implement OpenSSL version of CreateSelfSigned.
-#if !defined(USE_OPENSSL)
-
TEST_F(ServerBoundCertServiceTest, GetCacheMiss) {
std::string host("encrypted.google.com");
@@ -775,7 +769,7 @@ TEST_F(ServerBoundCertServiceTest, AsyncStoreGetThenCreateNoCertsInStore) {
EXPECT_FALSE(request_handle2.is_active());
}
-#endif // !defined(USE_OPENSSL)
+
wtc 2014/03/25 17:18:28 Nit: Delete one blank line.
haavardm 2014/03/26 12:25:18 Done.
} // namespace

Powered by Google App Engine
This is Rietveld 408576698