Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Unified Diff: net/net.gyp

Issue 206453002: Introduce USE_OPENSSL_CERTS for certificate handling. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changed meaning of USE_OPENSSL_CERTS Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/net.gyp
diff --git a/net/net.gyp b/net/net.gyp
index 3dc081e56bee74294191809c326fad802f7ebdc3..f2ca051b0a4dd3d7e003fa184f1800045c9bb09a 100644
--- a/net/net.gyp
+++ b/net/net.gyp
@@ -1418,17 +1418,9 @@
'sources!': [
'base/crypto_module_openssl.cc',
'base/keygen_handler_openssl.cc',
- 'base/openssl_private_key_store.h',
- 'base/openssl_private_key_store_android.cc',
- 'base/openssl_private_key_store_memory.cc',
- 'cert/cert_database_openssl.cc',
- 'cert/cert_verify_proc_openssl.cc',
- 'cert/cert_verify_proc_openssl.h',
'cert/ct_log_verifier_openssl.cc',
'cert/ct_objects_extractor_openssl.cc',
'cert/jwk_serializer_openssl.cc',
- 'cert/test_root_certs_openssl.cc',
- 'cert/x509_certificate_openssl.cc',
'cert/x509_util_openssl.cc',
'cert/x509_util_openssl.h',
'quic/crypto/aead_base_decrypter_openssl.cc',
@@ -1446,25 +1438,38 @@
'socket/ssl_server_socket_openssl.cc',
'socket/ssl_session_cache_openssl.cc',
'socket/ssl_session_cache_openssl.h',
- 'ssl/openssl_client_key_store.cc',
- 'ssl/openssl_client_key_store.h',
],
},
],
+ [ 'use_openssl_certs == 0', {
+ 'sources!': [
+ 'base/openssl_private_key_store.h',
+ 'base/openssl_private_key_store_android.cc',
+ 'base/openssl_private_key_store_memory.cc',
+ 'cert/cert_database_openssl.cc',
+ 'cert/cert_verify_proc_openssl.cc',
+ 'cert/cert_verify_proc_openssl.h',
+ 'cert/test_root_certs_openssl.cc',
+ 'cert/x509_certificate_openssl.cc',
+ 'ssl/openssl_client_key_store.cc',
+ 'ssl/openssl_client_key_store.h',
+ ],
+ }],
[ 'use_glib == 1', {
'dependencies': [
'../build/linux/system.gyp:gconf',
'../build/linux/system.gyp:gio',
],
}],
+ [ 'use_openssl == 1', {
wtc 2014/03/25 17:18:28 Merge this with the existing use_openssl==1 block
haavardm 2014/03/26 12:25:18 Done.
+ 'dependencies': [
+ '../third_party/openssl/openssl.gyp:openssl',
+ ],
+ }],
[ 'desktop_linux == 1 or chromeos == 1', {
'conditions': [
- ['use_openssl==1', {
- 'dependencies': [
- '../third_party/openssl/openssl.gyp:openssl',
- ],
- },
- { # else use_openssl==0, use NSS
+ ['use_openssl == 0', {
+ # use NSS
'dependencies': [
'../build/linux/system.gyp:ssl',
],
@@ -1573,10 +1578,15 @@
},
],
[ 'OS == "mac"', {
- 'dependencies': [
- '../third_party/nss/nss.gyp:nspr',
- '../third_party/nss/nss.gyp:nss',
- 'third_party/nss/ssl.gyp:libssl',
+ 'conditions': [
+ [ 'use_openssl == 0', {
+ 'dependencies': [
+ # defaults to nss
+ '../third_party/nss/nss.gyp:nspr',
+ '../third_party/nss/nss.gyp:nss',
+ 'third_party/nss/ssl.gyp:libssl',
+ ],
+ }],
],
'link_settings': {
'libraries': [
@@ -2266,10 +2276,14 @@
'quic/test_tools/crypto_test_utils_openssl.cc',
'socket/ssl_client_socket_openssl_unittest.cc',
'socket/ssl_session_cache_openssl_unittest.cc',
- 'ssl/openssl_client_key_store_unittest.cc',
],
},
],
+ [ 'use_openssl_certs == 0', {
+ 'sources!': [
+ 'ssl/openssl_client_key_store_unittest.cc',
+ ],
+ }],
[ 'enable_websockets != 1', {
'sources/': [
['exclude', '^socket_stream/'],
@@ -2337,7 +2351,7 @@
'msvs_disabled_warnings': [4267, ],
},
],
- [ 'OS == "mac"', {
+ [ 'OS == "mac" and use_openssl == 0', {
'dependencies': [
'../third_party/nss/nss.gyp:nspr',
'../third_party/nss/nss.gyp:nss',

Powered by Google App Engine
This is Rietveld 408576698