Introduce USE_OPENSSL_CERTS for certificate handling.

crypto/crypto.gyp

Index: crypto/crypto.gyp
diff --git a/crypto/crypto.gyp b/crypto/crypto.gyp
index 23b29861c3f749773da4cede16f2aeffeb926758..7c88e46f6b93ba037f700e855d73c231874b013f 100644
--- a/crypto/crypto.gyp
+++ b/crypto/crypto.gyp
@@ -80,7 +80,7 @@
             'mac_security_services_lock.h',
           ],
         }],
-        [ 'OS == "mac" or OS == "ios" or OS == "win"', {
+        [ 'use_openssl == 0 and (OS == "mac" or OS == "ios" or OS == "win")', {
           'dependencies': [
             '../third_party/nss/nss.gyp:nspr',
             '../third_party/nss/nss.gyp:nss',
@@ -201,12 +201,12 @@
             'openpgp_symmetric_encryption_unittest.cc',

[wtc, 2014/03/27 17:40:18]

I believe openpgp_symmetric_encryption_unittest.cc is incorrectly excluded in
this build configuration. I will deal with this separately.

[wtc, 2014/03/27 18:26:25]

I was wrong. openpgp_symmetric_encryption_unittest.cc needs to be excluded
because openpgp_symmetric_encryption.h and openpgp_symmetric_encryption.cc are
excluded in this build configuration.

           ]
         }],
-        [ 'OS == "mac" or OS == "ios" or OS == "win"', {
+        [ 'use_openssl == 0 and (OS == "mac" or OS == "ios" or OS == "win")', {
           'dependencies': [
             '../third_party/nss/nss.gyp:nss',

[wtc, 2014/03/27 17:40:18]

I misunderstood what export_dependent_settings means. Sorry about the wrong
suggestion.

The unresolved symbol PR_ImplodeTime shows crypto_unittests
(nss_util_unittest.cc) calls that NSPR function. So crypto_unittests needs to
have a dependency on nss.gyp:nspr. The dependency on nss.gyp:nss doesn't seem
necessary.

So I suggest changing this line to
    '../third_party/nss/nss.gyp:nspr',

and remove lines 209-213.

[haavardm, 2014/03/27 21:10:58]

Done. 

It still confuses me why nspr is needed for the PR_ImplodeTime() as this
function is implemented and (always?) compiled at
src/base/third_party/nspr/prtime.cc.

[wtc, 2014/03/27 21:16:03]

I forgot to answer that question. src/base/third_party/nspr/prtime.cc is a
forked copy of the NSPR source file prtime.c. It is internal to the base
component. nss_util_unittest.cc needs to get the PR_ImplodeTime function from
the real NSPR.

           ],
         }],
-        [ 'OS == "mac"', {
+        [ 'use_openssl == 0 and OS == "mac"', {
           'dependencies': [
             '../third_party/nss/nss.gyp:nspr',
           ],