Introduce USE_OPENSSL_CERTS for certificate handling.

crypto/crypto.gyp

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     'chromium_code': 1,
   },
   'includes': [
     'crypto.gypi',
@@ skipping 62 matching lines @@
             ],
           },
         }, {  # OS != "mac"
           'sources!': [
             'cssm_init.cc',
             'cssm_init.h',
             'mac_security_services_lock.cc',
             'mac_security_services_lock.h',
           ],
         }],
-        [ 'OS == "mac" or OS == "ios" or OS == "win"', {
+        [ 'use_openssl == 0 and (OS == "mac" or OS == "ios" or OS == "win")', {
           'dependencies': [
             '../third_party/nss/nss.gyp:nspr',
             '../third_party/nss/nss.gyp:nss',
           ],
           'export_dependent_settings': [
             '../third_party/nss/nss.gyp:nspr',
             '../third_party/nss/nss.gyp:nss',
           ],
         }],
         [ 'OS != "win"', {
@@ skipping 97 matching lines @@
                 ],
               },
             ],
           ],
           'dependencies': [
             '../build/linux/system.gyp:ssl',
           ],
         }, {  # os_posix != 1 or OS == "mac" or OS == "android" or OS == "ios"
           'sources!': [
             'rsa_private_key_nss_unittest.cc',
             'openpgp_symmetric_encryption_unittest.cc',

[wtc, 2014/03/27 17:40:18]

I believe openpgp_symmetric_encryption_unittest.cc is incorrectly excluded in
this build configuration. I will deal with this separately.

[wtc, 2014/03/27 18:26:25]

I was wrong. openpgp_symmetric_encryption_unittest.cc needs to be excluded
because openpgp_symmetric_encryption.h and openpgp_symmetric_encryption.cc are
excluded in this build configuration.

           ]
         }],
-        [ 'OS == "mac" or OS == "ios" or OS == "win"', {
+        [ 'use_openssl == 0 and (OS == "mac" or OS == "ios" or OS == "win")', {
           'dependencies': [
             '../third_party/nss/nss.gyp:nss',

[wtc, 2014/03/27 17:40:18]

I misunderstood what export_dependent_settings means. Sorry about the wrong
suggestion.

The unresolved symbol PR_ImplodeTime shows crypto_unittests
(nss_util_unittest.cc) calls that NSPR function. So crypto_unittests needs to
have a dependency on nss.gyp:nspr. The dependency on nss.gyp:nss doesn't seem
necessary.

So I suggest changing this line to
    '../third_party/nss/nss.gyp:nspr',

and remove lines 209-213.

[haavardm, 2014/03/27 21:10:58]

Done. 

It still confuses me why nspr is needed for the PR_ImplodeTime() as this
function is implemented and (always?) compiled at
src/base/third_party/nspr/prtime.cc.

[wtc, 2014/03/27 21:16:03]

I forgot to answer that question. src/base/third_party/nspr/prtime.cc is a
forked copy of the NSPR source file prtime.c. It is internal to the base
component. nss_util_unittest.cc needs to get the PR_ImplodeTime function from
the real NSPR.

           ],
         }],
-        [ 'OS == "mac"', {
+        [ 'use_openssl == 0 and OS == "mac"', {
           'dependencies': [
             '../third_party/nss/nss.gyp:nspr',
           ],
         }],
         [ 'OS == "win"', {
           # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
           'msvs_disabled_warnings': [4267, ],
         }],
         [ 'use_openssl==1', {
           'sources!': [
@@ skipping 31 matching lines @@
           'configurations': {
             'Common_Base': {
               'msvs_target_platform': 'x64',
             },
           },
         },
       ],
     }],
   ],
 }