Mojo interface/service for Leak Detector on remote process

chrome/browser/metrics/leak_detector/leak_detector_remote_controller.h

Index: chrome/browser/metrics/leak_detector/leak_detector_remote_controller.h
diff --git a/chrome/browser/metrics/leak_detector/leak_detector_remote_controller.h b/chrome/browser/metrics/leak_detector/leak_detector_remote_controller.h
new file mode 100644
index 0000000000000000000000000000000000000000..613bbb3586a3a56115c7e87ec8085825eb6be64a
--- /dev/null
+++ b/chrome/browser/metrics/leak_detector/leak_detector_remote_controller.h
@@ -0,0 +1,66 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_METRICS_LEAK_DETECTOR_LEAK_DETECTOR_REMOTE_CONTROLLER_H_
+#define CHROME_BROWSER_METRICS_LEAK_DETECTOR_LEAK_DETECTOR_REMOTE_CONTROLLER_H_
+
+#include <string>
+#include <vector>
+
+#include "base/macros.h"
+#include "components/metrics/leak_detector/leak_detector.mojom.h"
+#include "components/metrics/proto/memory_leak_report.pb.h"
+#include "mojo/public/cpp/bindings/interface_request.h"
+#include "mojo/public/cpp/bindings/strong_binding.h"
+
+namespace metrics {
+
+// This class acts as an interface to LeakDetector clients running on processes
+// other than its own (the browser process).
+class LeakDetectorRemoteController : public mojom::LeakDetector {
+ public:
+  // Interface class to be implemented by a local controller class that provides
+  // leak detector parameters and can pass leak reports to UMA.
+  class LocalController {
+   public:
+    virtual ~LocalController() {}
+
+    // Returns a set of leak detection params to be used when initializing the
+    // leak detector on a remote process.
+    virtual MemoryLeakReportProto::Params GetParams() const = 0;
+
+    // Pass a vector of memory leak reports provided by a remote process to the
+    // local controller class.
+    virtual void SendLeakReports(
+        const std::vector<MemoryLeakReportProto>& reports) = 0;
+
+    // Signal that a remote process that had been running the leak detector
+    // (i.e. been given params with sampling_rate = 0).
+    virtual void OnRemoteProcessShutdown() = 0;
+  };
+
+  ~LeakDetectorRemoteController() override;
+
+  static void Create(mojom::LeakDetectorRequest request);
+
+  // mojom::LeakDetector:
+  void GetParams(
+      const mojom::LeakDetector::GetParamsCallback& callback) override;
+  void SendLeakReports(mojo::Array<mojom::MemoryLeakReportPtr>) override;
+
+  // Sets a global pointer to a LocalController implementation. The global
+  // pointer is defined in the .cc file.
+  static void SetLocalControllerInstance(LocalController* controller);

[jochen (gone - plz use gerrit), 2016/07/18 11:40:55]

where is this called from?

[Simon Que, 2016/07/18 18:50:21]

Currently not being called. In a subsequent CL, this will be called from
chrome/browser/chrome_content_browser_client.cc. I also plan to add some code to
randomly enable leak detection on the remote process (vs 100% of the time), to
avoid overloading the system with overhead. Since there's already so much in
this CL, I'd like to save that for the next one.

+
+ private:
+  explicit LeakDetectorRemoteController(mojom::LeakDetectorRequest request);
+
+  mojo::StrongBinding<mojom::LeakDetector> binding_;
+
+  DISALLOW_COPY_AND_ASSIGN(LeakDetectorRemoteController);
+};
+
+}  // namespace metrics
+
+#endif  // CHROME_BROWSER_METRICS_LEAK_DETECTOR_LEAK_DETECTOR_REMOTE_CONTROLLER_H_