Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5908)

Unified Diff: chrome/browser/metrics/leak_detector/leak_detector_controller.cc

Issue 2064463002: Mojo interface/service for Leak Detector on remote process (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Create BUILD.gn for chrome/renderer/leak_detector Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/leak_detector/leak_detector_controller.cc
diff --git a/chrome/browser/metrics/leak_detector/leak_detector_controller.cc b/chrome/browser/metrics/leak_detector/leak_detector_controller.cc
index a95597b27bd6a824d18e2b1f363ef4749b5184ce..68a01d44f83bc3f2e9a30b07b073c0b359d74589 100644
--- a/chrome/browser/metrics/leak_detector/leak_detector_controller.cc
+++ b/chrome/browser/metrics/leak_detector/leak_detector_controller.cc
@@ -103,21 +103,42 @@ LeakDetectorController::~LeakDetectorController() {
LeakDetector::GetInstance()->RemoveObserver(this);
}
+void LeakDetectorController::GetLeakReports(
+ std::vector<MemoryLeakReportProto>* reports) {
+ DCHECK(thread_checker_.CalledOnValidThread());
+ reports->swap(stored_reports_);
+ stored_reports_.clear();
+}
+
void LeakDetectorController::OnLeaksFound(
const std::vector<MemoryLeakReportProto>& reports) {
+ StoreLeakReports(reports, MemoryLeakReportProto::BROWSER_PROCESS);
+}
+
+MemoryLeakReportProto_Params LeakDetectorController::GetParams() const {
+ return params_;
+}
+
+void LeakDetectorController::SendLeakReports(
+ const std::vector<MemoryLeakReportProto>& reports) {
+ StoreLeakReports(reports, MemoryLeakReportProto::RENDERER_PROCESS);
+}
+
+void LeakDetectorController::OnRemoteProcessShutdown() {
+ // TODO(sque): Handle remote process shutdown.
+}
+
+void LeakDetectorController::StoreLeakReports(
+ const std::vector<MemoryLeakReportProto>& reports,
+ MemoryLeakReportProto::ProcessType process_type) {
DCHECK(thread_checker_.CalledOnValidThread());
for (const auto& report : reports) {
// Store the report and insert stored parameters.
stored_reports_.push_back(report);
stored_reports_.back().mutable_params()->CopyFrom(params_);
+ stored_reports_.back().set_source_process(process_type);
}
}
-void LeakDetectorController::GetLeakReports(
- std::vector<MemoryLeakReportProto>* reports) {
- DCHECK(thread_checker_.CalledOnValidThread());
- *reports = std::move(stored_reports_);
-}
-
} // namespace metrics

Powered by Google App Engine
This is Rietveld 408576698