components/offline_pages/background/request_coordinator.h - Issue 2064323004: Defines initial DeviceConditions and and plumbs down through StartProcessing() call.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/background/request_coordinator.h

Issue 2064323004: Defines initial DeviceConditions and and plumbs down through StartProcessing() call. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: merge Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/offline_pages/background/device_conditions.h ('k') | components/offline_pages/background/request_coordinator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_pages/background/request_coordinator.h

diff --git a/components/offline_pages/background/request_coordinator.h b/components/offline_pages/background/request_coordinator.h

index dddcca8d49568d62a029e441d1d5e19d92b83500..ffbb8570499257b13d5d6f8b66ab650d85d5e887 100644

--- a/components/offline_pages/background/request_coordinator.h

+++ b/components/offline_pages/background/request_coordinator.h

@@ -11,6 +11,7 @@

#include "base/macros.h"

#include "base/memory/weak_ptr.h"

#include "components/keyed_service/core/keyed_service.h"

+#include "components/offline_pages/background/device_conditions.h"

#include "components/offline_pages/background/offliner.h"

#include "components/offline_pages/background/request_queue.h"

#include "url/gurl.h"

@@ -47,7 +48,8 @@ class RequestCoordinator : public KeyedService {

// Starts processing of one or more queued save page later requests.

// Returns whether processing was started and that caller should expect

// a callback. If processing was already active, returns false.

- bool StartProcessing(const base::Callback<void(bool)>& callback);

+ bool StartProcessing(const DeviceConditions& device_conditions,

+ const base::Callback<void(bool)>& callback);

// Stops the current request processing if active. This is a way for

// caller to abort processing; otherwise, processing will complete on