components/offline_pages/background/request_coordinator.cc - Issue 2064323004: Defines initial DeviceConditions and and plumbs down through StartProcessing() call.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/background/request_coordinator.cc

Issue 2064323004: Defines initial DeviceConditions and and plumbs down through StartProcessing() call. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: merge Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/offline_pages/background/request_coordinator.h ('k') | components/offline_pages/background/request_coordinator_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_pages/background/request_coordinator.cc

diff --git a/components/offline_pages/background/request_coordinator.cc b/components/offline_pages/background/request_coordinator.cc

index ffbd5bf3e536aae3aa385063c6b18f1f45ffa8c0..a910ff2307b7a8859275ef24555df9f6e99f6e64 100644

--- a/components/offline_pages/background/request_coordinator.cc

+++ b/components/offline_pages/background/request_coordinator.cc

@@ -86,6 +86,7 @@ void RequestCoordinator::RequestQueueEmpty() {

}

bool RequestCoordinator::StartProcessing(

+ const DeviceConditions& device_conditions,

const base::Callback<void(bool)>& callback) {

scheduler_callback_ = callback;

// TODO(petewil): Check existing conditions (should be passed down from

@@ -145,7 +146,6 @@ void RequestCoordinator::OfflinerDoneCallback(const SavePageRequest& request,

// TODO(petewil): Check time budget. Return to the scheduler if we are out.

// Start a request if we have time.

TryNextRequest();

}