Reland: "Sync: Support multiple setup UIs."

Reland: "Sync: Support multiple setup UIs."

This reverts commit 06bbee4ce66d8827fd9c6a35f404fd21376f75a7.

The bug was caused by SupervisedUserService not releasing sync_blocker_ in Shutdown, as it should.

BUG=563721, 620019
TBR=

Committed: https://crrev.com/f3a1551ea5b8c94fc4c915113f840ca5ca6c78aa
Cr-Commit-Position: refs/heads/master@{#401048}

[tommycli, 2016-06-14 17:06:58]

Description was changed from

==========
Reland: "Sync: Support multiple setup UIs."

This reverts commit 06bbee4ce66d8827fd9c6a35f404fd21376f75a7.

BUG=563721
==========

to

==========
Reland: "Sync: Support multiple setup UIs."

This reverts commit 06bbee4ce66d8827fd9c6a35f404fd21376f75a7.

The bug was caused by SupervisedUserService not releasing sync_blocker_ in
Shutdown, as it should.

BUG=563721
==========

[tommycli, 2016-06-14 17:09:35]

Description was changed from

==========
Reland: "Sync: Support multiple setup UIs."

This reverts commit 06bbee4ce66d8827fd9c6a35f404fd21376f75a7.

The bug was caused by SupervisedUserService not releasing sync_blocker_ in
Shutdown, as it should.

BUG=563721
==========

to

==========
Reland: "Sync: Support multiple setup UIs."

This reverts commit 06bbee4ce66d8827fd9c6a35f404fd21376f75a7.

The bug was caused by SupervisedUserService not releasing sync_blocker_ in
Shutdown, as it should.

BUG=563721
TBR=
==========

[tommycli, 2016-06-14 17:09:40]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-14 17:10:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2064183002/20001

[commit-bot: I haz the power, 2016-06-14 18:15:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-14 18:15:59]

Dry run: This issue passed the CQ dry run.

[tommycli, 2016-06-14 18:24:07]

tommycli@chromium.org changed reviewers:
+ thestig@chromium.org

[tommycli, 2016-06-14 18:24:08]

thestig: PTAL.

I reproduced the test failure locally, and added a line (in patchset 2) that
fixes the failure.

Thanks!

[Lei Zhang, 2016-06-14 18:26:58]

lgtm

[tommycli, 2016-06-14 18:27:14]

thestig: thanks!

[kjellander_chromium, 2016-06-14 19:06:28]

On 2016/06/14 18:27:14, tommycli wrote:
> thestig: thanks!

lgtm, but I suggest running a win_chromium_dbg_ng tryjob as well to be sure.

[Nicolas Zea, 2016-06-14 20:00:28]

On 2016/06/14 19:06:28, kjellander_chromium wrote:
> On 2016/06/14 18:27:14, tommycli wrote:
> > thestig: thanks!
> 
> lgtm, but I suggest running a win_chromium_dbg_ng tryjob as well to be sure.

Before relanding this, could you take a look at crbug.com/620019 to make sure
this isn't causing a regression?

[tommycli, 2016-06-14 20:30:35]

On 2016/06/14 20:00:28, Nicolas Zea wrote:
> On 2016/06/14 19:06:28, kjellander_chromium wrote:
> > On 2016/06/14 18:27:14, tommycli wrote:
> > > thestig: thanks!
> > 
> > lgtm, but I suggest running a win_chromium_dbg_ng tryjob as well to be sure.
> 
> Before relanding this, could you take a look at crbug.com/620019 to make sure
> this isn't causing a regression?

zea: Offhand that definitely looks like this patch was the culprit. I'll
investigate before relanding. Thanks!

[tommycli, 2016-06-21 17:02:15]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2016-06-21 17:02:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
thestig@chromium.org, kjellander@chromium.org
Link to the patchset: https://codereview.chromium.org/2064183002/#ps40001
(title: "Merge branch 'master' of https://chromium.googlesource.com/chromium/src
into 0183-settings-sync-rel…")

[commit-bot: I haz the power, 2016-06-21 17:02:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2064183002/40001

[tommycli, 2016-06-21 17:03:01]

zea: I have confirmed with manual testing that the weak_factory_ fix resolves
this bug: https://bugs.chromium.org/p/chromium/issues/detail?id=620019

I'm resubmitting this patch. Thanks!

[tommycli, 2016-06-21 17:03:24]

Description was changed from

==========
Reland: "Sync: Support multiple setup UIs."

This reverts commit 06bbee4ce66d8827fd9c6a35f404fd21376f75a7.

The bug was caused by SupervisedUserService not releasing sync_blocker_ in
Shutdown, as it should.

BUG=563721
TBR=
==========

to

==========
Reland: "Sync: Support multiple setup UIs."

This reverts commit 06bbee4ce66d8827fd9c6a35f404fd21376f75a7.

The bug was caused by SupervisedUserService not releasing sync_blocker_ in
Shutdown, as it should.

BUG=563721,620019
TBR=
==========

[commit-bot: I haz the power, 2016-06-21 18:11:43]

Description was changed from

==========
Reland: "Sync: Support multiple setup UIs."

This reverts commit 06bbee4ce66d8827fd9c6a35f404fd21376f75a7.

The bug was caused by SupervisedUserService not releasing sync_blocker_ in
Shutdown, as it should.

BUG=563721,620019
TBR=
==========

to

==========
Reland: "Sync: Support multiple setup UIs."

This reverts commit 06bbee4ce66d8827fd9c6a35f404fd21376f75a7.

The bug was caused by SupervisedUserService not releasing sync_blocker_ in
Shutdown, as it should.

BUG=563721,620019
TBR=
==========

[commit-bot: I haz the power, 2016-06-21 18:11:45]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-21 18:16:50]

Description was changed from

==========
Reland: "Sync: Support multiple setup UIs."

This reverts commit 06bbee4ce66d8827fd9c6a35f404fd21376f75a7.

The bug was caused by SupervisedUserService not releasing sync_blocker_ in
Shutdown, as it should.

BUG=563721,620019
TBR=
==========

to

==========
Reland: "Sync: Support multiple setup UIs."

This reverts commit 06bbee4ce66d8827fd9c6a35f404fd21376f75a7.

The bug was caused by SupervisedUserService not releasing sync_blocker_ in
Shutdown, as it should.

BUG=563721,620019
TBR=

Committed: https://crrev.com/f3a1551ea5b8c94fc4c915113f840ca5ca6c78aa
Cr-Commit-Position: refs/heads/master@{#401048}
==========

[commit-bot: I haz the power, 2016-06-21 18:16:52]

Patchset 3 (id:??) landed as
https://crrev.com/f3a1551ea5b8c94fc4c915113f840ca5ca6c78aa
Cr-Commit-Position: refs/heads/master@{#401048}