components/browser_sync/browser/profile_sync_service_unittest.cc - Issue 2064183002: Reland: "Sync: Support multiple setup UIs."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/browser_sync/browser/profile_sync_service_unittest.cc

Issue 2064183002: Reland: "Sync: Support multiple setup UIs." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge branch 'master' of https://chromium.googlesource.com/chromium/src into 0183-settings-sync-rel… Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/browser_sync/browser/profile_sync_service_unittest.cc

diff --git a/components/browser_sync/browser/profile_sync_service_unittest.cc b/components/browser_sync/browser/profile_sync_service_unittest.cc

index df901a476e667115b8d47e114b38dc6dbfcf2cda..92ceb54e375685eddea5b468430c1e680f676785 100644

--- a/components/browser_sync/browser/profile_sync_service_unittest.cc

+++ b/components/browser_sync/browser/profile_sync_service_unittest.cc

@@ -424,9 +424,9 @@ TEST_F(ProfileSyncServiceTest, SetupInProgress) {

TestSyncServiceObserver observer(service());

service()->AddObserver(&observer);

- service()->SetSetupInProgress(true);

+ auto sync_blocker = service()->GetSetupInProgressHandle();

EXPECT_TRUE(observer.setup_in_progress());

- service()->SetSetupInProgress(false);

+ sync_blocker.reset();

EXPECT_FALSE(observer.setup_in_progress());

service()->RemoveObserver(&observer);