Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 2064173002: Revert of gn BUILD fixes for disabling enable_extensions and use_ash feature flags. (Closed)

Created:
4 years, 6 months ago by James Cook
Modified:
4 years, 6 months ago
CC:
chromium-reviews, devtools-reviews_chromium.org, feature-media-reviews_chromium.org, media-router+watch_chromium.org, pfeldman, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of gn BUILD fixes for disabling enable_extensions and use_ash feature flags. (patchset #7 id:120001 of https://codereview.chromium.org/1950003002/ ) Reason for revert: Breaks the chromium.chromiumos gn builder. Repro: gn args out/Default Set to: is_component_build = true use_goma = true target_os = "chromeos" gn gen reports error: ERROR Unresolved dependencies. //:both_gn_and_gyp(//build/toolchain/cros:clang_target) needs //extensions/shell:app_shell(//build/toolchain/cros:clang_target) See https://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=Linux%20ChromiumOS%20GN%20%28dbg%29&number=22111 Original issue's description: > gn BUILD fixes for disabling enable_extensions and use_ash feature flags. > > BUG= > > Committed: https://crrev.com/2e75c702de464a5cc1cd2272ef720fbe1068c141 > Cr-Commit-Position: refs/heads/master@{#399693} TBR=dgozman@chromium.org,dpranke@google.com,dpranke@chromium.org,mfoltz@chromium.org,ben@chromium.org,asaka@opera.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/fbbf91109648c25132775c8f5e180128780303b9 Cr-Commit-Position: refs/heads/master@{#399721}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -36 lines) Patch
M BUILD.gn View 4 chunks +9 lines, -12 lines 0 comments Download
M build/config/features.gni View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/devtools/BUILD.gn View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/media/router/BUILD.gn View 3 chunks +5 lines, -8 lines 0 comments Download
M chrome/test/BUILD.gn View 4 chunks +4 lines, -12 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
James Cook
Created Revert of gn BUILD fixes for disabling enable_extensions and use_ash feature flags.
4 years, 6 months ago (2016-06-14 16:24:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2064173002/1
4 years, 6 months ago (2016-06-14 16:24:21 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-14 16:25:27 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-14 16:25:28 UTC) #6
Dirk Pranke
lgtm
4 years, 6 months ago (2016-06-14 16:27:05 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 16:27:17 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fbbf91109648c25132775c8f5e180128780303b9
Cr-Commit-Position: refs/heads/master@{#399721}

Powered by Google App Engine
This is Rietveld 408576698