Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issue 206413003: Fix Repaint-After-Layout after partial layout removal. (Closed)

Created:
6 years, 9 months ago by dsinclair
Modified:
6 years, 9 months ago
CC:
blink-reviews
Visibility:
Public.

Description

Fix Repaint-After-Layout after partial layout removal. When the partial layout code was removed this changed the conditional for triggering repaintTree from m_doFullRepaint || !partialLayout.isStopping() to just m_doFullRepaint. This caused repaint to not happen in a lot of cases because, typically, !paritalLayout.isStopping() was true and would trigger repaintTree. I don't think we need the check at all and should be unconditionally triggering repaintTree and using the information from layout to determine what repaints. BUG=283623, 320139 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169656

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M Source/core/frame/FrameView.cpp View 1 chunk +1 line, -2 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
dsinclair
PTAL.
6 years, 9 months ago (2014-03-20 12:56:24 UTC) #1
Julien - ping for review
lgtm https://codereview.chromium.org/206413003/diff/1/Source/core/frame/FrameView.cpp File Source/core/frame/FrameView.cpp (right): https://codereview.chromium.org/206413003/diff/1/Source/core/frame/FrameView.cpp#newcode1007 Source/core/frame/FrameView.cpp:1007: repaintTree(rootForThisLayout); We talked about this with Dan: this ...
6 years, 9 months ago (2014-03-20 15:06:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dsinclair@chromium.org/206413003/1
6 years, 9 months ago (2014-03-20 15:06:56 UTC) #3
commit-bot: I haz the power
6 years, 9 months ago (2014-03-20 15:15:39 UTC) #4
Message was sent while issue was closed.
Change committed as 169656

Powered by Google App Engine
This is Rietveld 408576698