Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Side by Side Diff: Source/core/frame/FrameView.cpp

Issue 206413003: Fix Repaint-After-Layout after partial layout removal. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 986 matching lines...) Expand 10 before | Expand all | Expand 10 after
997 InspectorInstrumentation::didLayout(cookie, rootForThisLayout); 997 InspectorInstrumentation::didLayout(cookie, rootForThisLayout);
998 998
999 m_nestedLayoutCount--; 999 m_nestedLayoutCount--;
1000 if (m_nestedLayoutCount) 1000 if (m_nestedLayoutCount)
1001 return; 1001 return;
1002 1002
1003 if (RuntimeEnabledFeatures::repaintAfterLayoutEnabled()) { 1003 if (RuntimeEnabledFeatures::repaintAfterLayoutEnabled()) {
1004 if (m_doFullRepaint) 1004 if (m_doFullRepaint)
1005 renderView()->setShouldDoFullRepaintAfterLayout(true); 1005 renderView()->setShouldDoFullRepaintAfterLayout(true);
1006 1006
1007 if (m_doFullRepaint) 1007 repaintTree(rootForThisLayout);
Julien - ping for review 2014/03/20 15:06:46 We talked about this with Dan: this will cause us
1008 repaintTree(rootForThisLayout);
1009 1008
1010 } else if (m_doFullRepaint) { 1009 } else if (m_doFullRepaint) {
1011 // FIXME: This isn't really right, since the RenderView doesn't fully en compass 1010 // FIXME: This isn't really right, since the RenderView doesn't fully en compass
1012 // the visibleContentRect(). It just happens to work out most of the tim e, 1011 // the visibleContentRect(). It just happens to work out most of the tim e,
1013 // since first layouts and printing don't have you scrolled anywhere. 1012 // since first layouts and printing don't have you scrolled anywhere.
1014 renderView()->repaint(); 1013 renderView()->repaint();
1015 } 1014 }
1016 1015
1017 m_doFullRepaint = false; 1016 m_doFullRepaint = false;
1018 1017
(...skipping 2197 matching lines...) Expand 10 before | Expand all | Expand 10 after
3216 void FrameView::willRemoveScrollbar(Scrollbar* scrollbar, ScrollbarOrientation o rientation) 3215 void FrameView::willRemoveScrollbar(Scrollbar* scrollbar, ScrollbarOrientation o rientation)
3217 { 3216 {
3218 ScrollableArea::willRemoveScrollbar(scrollbar, orientation); 3217 ScrollableArea::willRemoveScrollbar(scrollbar, orientation);
3219 if (AXObjectCache* cache = axObjectCache()) { 3218 if (AXObjectCache* cache = axObjectCache()) {
3220 cache->remove(scrollbar); 3219 cache->remove(scrollbar);
3221 cache->handleScrollbarUpdate(this); 3220 cache->handleScrollbarUpdate(this);
3222 } 3221 }
3223 } 3222 }
3224 3223
3225 } // namespace WebCore 3224 } // namespace WebCore
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698