DescriptionRevert of Drop unecessary use of CrossThreadPersistent by CanvasAsyncBlobCreator. (patchset #1 id:1 of https://codereview.chromium.org/2051993002/ )
Reason for revert:
Breaks WebKit Linux Leak bot:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/20274
unexpected_failures:
virtual/threaded/fast/canvas-toBlob/canvas-toBlob-file-vs-blob.html
virtual/display_list_2d_canvas/fast/canvas/canvas-toBlob-toDataURL-race-imageEncoder-jpeg.html
virtual/threaded/fast/canvas-toBlob/canvas-toBlob-invalid.html
fast/canvas/canvas-toBlob-toDataURL-race-imageEncoder-jpeg.html
virtual/gpu/fast/canvas/canvas-toBlob-toDataURL-race-imageEncoder-jpeg.html
virtual/threaded/fast/canvas-toBlob/canvas-toBlob-defaultpng.html
virtual/gpu/fast/canvas/canvas-toBlob-jpeg-medium-quality.html
Original issue's description:
> Drop unecessary use of CrossThreadPersistent by CanvasAsyncBlobCreator.
>
> The callback object that the CanvasAsyncBlobCreator passes along to a
> background thread can be kept as a simple Member<>; no need to
> involve CrossThreadPersistent<> and risk inadvertently introducing
> leaks.
>
> R=
> BUG=
>
> Committed: https://crrev.com/089aa85a72d06184c60104b1c1c6f84d1e2eb334
> Cr-Commit-Position: refs/heads/master@{#399181}
TBR=oilpan-reviews@chromium.org,sigbjornf@opera.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=
Patch Set 1 #
Messages
Total messages: 8 (3 generated)
|