Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1274)

Issue 2064123002: Revert of Drop unecessary use of CrossThreadPersistent by CanvasAsyncBlobCreator. (Closed)

Created:
4 years, 6 months ago by kjellander_chromium
Modified:
4 years, 6 months ago
Reviewers:
oilpan-reviews, sof
CC:
chromium-reviews, dshwang, ajuma+watch-canvas_chromium.org, blink-reviews-html_chromium.org, Justin Novosad, dglazkov+blink, Rik, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Drop unecessary use of CrossThreadPersistent by CanvasAsyncBlobCreator. (patchset #1 id:1 of https://codereview.chromium.org/2051993002/ ) Reason for revert: Breaks WebKit Linux Leak bot: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/20274 unexpected_failures: virtual/threaded/fast/canvas-toBlob/canvas-toBlob-file-vs-blob.html virtual/display_list_2d_canvas/fast/canvas/canvas-toBlob-toDataURL-race-imageEncoder-jpeg.html virtual/threaded/fast/canvas-toBlob/canvas-toBlob-invalid.html fast/canvas/canvas-toBlob-toDataURL-race-imageEncoder-jpeg.html virtual/gpu/fast/canvas/canvas-toBlob-toDataURL-race-imageEncoder-jpeg.html virtual/threaded/fast/canvas-toBlob/canvas-toBlob-defaultpng.html virtual/gpu/fast/canvas/canvas-toBlob-jpeg-medium-quality.html Original issue's description: > Drop unecessary use of CrossThreadPersistent by CanvasAsyncBlobCreator. > > The callback object that the CanvasAsyncBlobCreator passes along to a > background thread can be kept as a simple Member<>; no need to > involve CrossThreadPersistent<> and risk inadvertently introducing > leaks. > > R= > BUG= > > Committed: https://crrev.com/089aa85a72d06184c60104b1c1c6f84d1e2eb334 > Cr-Commit-Position: refs/heads/master@{#399181} TBR=oilpan-reviews@chromium.org,sigbjornf@opera.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kjellander_chromium
Created Revert of Drop unecessary use of CrossThreadPersistent by CanvasAsyncBlobCreator.
4 years, 6 months ago (2016-06-14 11:50:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2064123002/1
4 years, 6 months ago (2016-06-14 11:50:22 UTC) #3
sof
Unchecked; leak bots will cycle green follwing https://crrev.com/399675.
4 years, 6 months ago (2016-06-14 11:52:11 UTC) #5
sof
On 2016/06/14 11:52:11, sof wrote: > Unchecked; leak bots will cycle green follwing https://crrev.com/399675. cf. ...
4 years, 6 months ago (2016-06-14 11:53:33 UTC) #6
kjellander_chromium
4 years, 6 months ago (2016-06-14 14:01:07 UTC) #7
On 2016/06/14 11:53:33, sof wrote:
> On 2016/06/14 11:52:11, sof wrote:
> > Unchecked; leak bots will cycle green follwing https://crrev.com/399675.
> 
> cf.
>
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/b...
> - leaks there are not related to the CL in Q.

OK thanks. I will compare with the latest build before I revert next time.

Powered by Google App Engine
This is Rietveld 408576698