[Findit] Fix 'Trigger same task twice' error.

[Findit] Fix 'Trigger same task twice' error.

There are duplicated test names in all_tests which leads to this error.

Fix this issue by only include one test in requested_tests_to_run with the same name as each step_name in requested_tests.

BUG=619776
Committed: https://chromium.googlesource.com/chromium/tools/build/+/2d0bb0f0e5b807f94d71140320d5b8b9de5a6408

[chanli, 2016-06-14 00:53:49]

ptal

[chanli, 2016-06-14 23:13:27]

chanli@chromium.org changed reviewers:
+ lijeffrey@chromium.org, stgao@chromium.org

[chanli, 2016-06-14 23:13:28]

ptal

[stgao, 2016-06-14 23:40:06]

https://codereview.chromium.org/2064033002/diff/1/scripts/slave/recipes/findi...
File scripts/slave/recipes/findit/chromium/test.py (right):

https://codereview.chromium.org/2064033002/diff/1/scripts/slave/recipes/findi...
scripts/slave/recipes/findit/chromium/test.py:103:
_check_and_remove_test_name(requested_test_names, test.name)]
This fix might cause issue.
Each test will has some corresponding settings in the test spec.

As we just select the first one in the list, it might not be for the
target_tester when a builder has 2+ attached testers.

It seems bot_id support both 'buildername' and 'tester' in
https://chromium.googlesource.com/chromium/tools/build/+blame/402d0b5f021aaa0...

We'd better use the target_testername to make sure the correct test is selected.
You may want to talk to phajdan.jr@chromium.org on this.

[chanli, 2016-06-15 03:29:31]

ptal

[stgao, 2016-06-15 05:22:15]

https://codereview.chromium.org/2064033002/diff/60001/scripts/slave/recipes/f...
File scripts/slave/recipes/findit/chromium/test.py (right):

https://codereview.chromium.org/2064033002/diff/60001/scripts/slave/recipes/f...
scripts/slave/recipes/findit/chromium/test.py:93: all_tests, _ =
api.chromium_tests.get_tests(bot_config, bot_db)
double check: without change to
https://chromium.googlesource.com/chromium/tools/build/+blame/402d0b5f021aaa0...,
will this work as expected?

[stgao, 2016-06-15 23:20:30]

As discussed offline, the fix should work.

lgtm

[stgao, 2016-06-15 23:20:42]

The CQ bit was checked by stgao@chromium.org

[commit-bot: I haz the power, 2016-06-15 23:20:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2064033002/60001

[commit-bot: I haz the power, 2016-06-15 23:24:20]

Description was changed from

==========
[Findit] Fix 'Trigger same task twice' error.

There are duplicated test names in all_tests which leads to this error.

Fix this issue by only include one test in requested_tests_to_run with the same
name as each step_name in requested_tests.

BUG=619776
==========

to

==========
[Findit] Fix 'Trigger same task twice' error.

There are duplicated test names in all_tests which leads to this error.

Fix this issue by only include one test in requested_tests_to_run with the same
name as each step_name in requested_tests.

BUG=619776

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/2d0bb0f0e5b807f94d71...
==========

[commit-bot: I haz the power, 2016-06-15 23:24:21]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/tools/build/+/2d0bb0f0e5b807f94d71...