Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Unified Diff: scripts/slave/recipes/findit/chromium/test.py

Issue 2064033002: [Findit] Fix 'Trigger same task twice' error. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: . Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipes/findit/chromium/test.py
diff --git a/scripts/slave/recipes/findit/chromium/test.py b/scripts/slave/recipes/findit/chromium/test.py
index dc2f10deba813ed362dab94755b3015e96ae415a..37d97e075ca469e4740ac0e019d41db73cd12959 100644
--- a/scripts/slave/recipes/findit/chromium/test.py
+++ b/scripts/slave/recipes/findit/chromium/test.py
@@ -80,13 +80,17 @@ def _compile_and_test_at_revision(api, target_mastername, target_buildername,
results = {}
with api.step.nest('test %s' % str(revision)):
# Checkout code at the given revision to recompile.
- bot_config = api.chromium_tests.create_bot_config_object(
- target_mastername, target_buildername)
+ bot_id = {
+ 'mastername': target_mastername,
+ 'buildername': target_buildername,
+ 'tester': target_testername}
+ bot_config = api.chromium_tests.create_generalized_bot_config_object(
+ [bot_id])
bot_update_step, bot_db = api.chromium_tests.prepare_checkout(
bot_config, root_solution_revision=revision)
# Figure out which test steps to run.
- _, all_tests = api.chromium_tests.get_tests(bot_config, bot_db)
+ all_tests, _ = api.chromium_tests.get_tests(bot_config, bot_db)
stgao 2016/06/15 05:22:15 double check: without change to https://chromium.g
requested_tests_to_run = [
test for test in all_tests if test.name in requested_tests]
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698