Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Issue 2063993002: Implement GetDeviceTypeName on cros. (Closed)

Created:
4 years, 6 months ago by achuithb
Modified:
4 years, 6 months ago
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Base URL:
https://github.com/catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Implement GetDeviceTypeName on cros. Parse /etc/lsb-release for DEVICETYPE field. BUG=chromium:619218 TEST=testLsbRelease Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/38ec185af4a052a2d4a0c4c39c9c6a4287b2b29e

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -1 line) Patch
M telemetry/telemetry/core/cros_interface.py View 1 chunk +13 lines, -0 lines 0 comments Download
M telemetry/telemetry/core/cros_interface_unittest.py View 1 chunk +8 lines, -0 lines 0 comments Download
M telemetry/telemetry/internal/platform/cros_platform_backend.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2063993002/20001
4 years, 6 months ago (2016-06-14 00:03:43 UTC) #3
achuithb
Kari, Dave, please take a look.
4 years, 6 months ago (2016-06-14 00:04:01 UTC) #5
aiolos (Not reviewing)
lgtm
4 years, 6 months ago (2016-06-14 00:16:35 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-14 01:15:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2063993002/20001
4 years, 6 months ago (2016-06-14 01:18:11 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 01:39:33 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698