telemetry/telemetry/core/cros_interface_unittest.py - Issue 2063993002: Implement GetDeviceTypeName on cros.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/core/cros_interface_unittest.py

Issue 2063993002: Implement GetDeviceTypeName on cros. (Closed) Base URL: https://github.com/catapult-project/catapult.git@master

Patch Set: . Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: telemetry/telemetry/core/cros_interface_unittest.py

diff --git a/telemetry/telemetry/core/cros_interface_unittest.py b/telemetry/telemetry/core/cros_interface_unittest.py

index 47480a4bcd9926b5a647bb1d66f0540a74fe488b..07b7f6be5fe2ea2517cdcdd7f18bd1738811d303 100644

--- a/telemetry/telemetry/core/cros_interface_unittest.py

+++ b/telemetry/telemetry/core/cros_interface_unittest.py

@@ -147,6 +147,14 @@ class CrOSInterfaceTest(unittest.TestCase):

'/var/log/screenshots/test-prefix-0.png'))

_Cleanup()

+ @decorators.Enabled('chromeos')

+ def testLsbReleaseValue(self):

+ with self._GetCRI() as cri:

+ build_num = cri.LsbReleaseValue('CHROMEOS_RELEASE_BUILD_NUMBER', None)

+ self.assertTrue(build_num.isdigit())

+ device_type = cri.LsbReleaseValue('DEVICETYPE', None)

+ self.assertTrue(device_type.isalpha())

# TODO(tengs): It would be best if we can filter this test and other tests

# that need to be run locally based on the platform of the system browser.

@decorators.Enabled('linux')