Issue 206393004: Remove HeapSnapshotItemIterator.rewind

Issue 206393004: Remove HeapSnapshotItemIterator.rewind (Closed)

Created:
6 years, 9 months ago by yurys

Modified:
6 years, 9 months ago

Reviewers:
alph, loislo

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove HeapSnapshotItemIterator.rewind We don't actually need to rewind iterators. The iterators should be one-pass only and rewind just complicates the code. BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169654

Patch Set 1 #

Total comments: 2

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -25 lines)			Patch
M	LayoutTests/inspector/profiler/heap-snapshot.html	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	Source/devtools/front_end/HeapSnapshot.js	View	6 chunks	+0 lines, -21 lines	0 comments	Download
M	Source/devtools/front_end/JSHeapSnapshot.js	View	1 chunk	+1 line, -1 line	2 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

loislo

lgtm https://codereview.chromium.org/206393004/diff/1/Source/devtools/front_end/JSHeapSnapshot.js File Source/devtools/front_end/JSHeapSnapshot.js (right): https://codereview.chromium.org/206393004/diff/1/Source/devtools/front_end/JSHeapSnapshot.js#newcode144 Source/devtools/front_end/JSHeapSnapshot.js:144: for (var innerIter = node.edges(); innerIter.hasNext(); innerIter.next()) { ...

6 years, 9 months ago (2014-03-20 13:16:40 UTC) #2

yurys

https://codereview.chromium.org/206393004/diff/1/Source/devtools/front_end/JSHeapSnapshot.js File Source/devtools/front_end/JSHeapSnapshot.js (right): https://codereview.chromium.org/206393004/diff/1/Source/devtools/front_end/JSHeapSnapshot.js#newcode144 Source/devtools/front_end/JSHeapSnapshot.js:144: for (var innerIter = node.edges(); innerIter.hasNext(); innerIter.next()) { On ...

6 years, 9 months ago (2014-03-20 13:19:04 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/206393004/1

6 years, 9 months ago (2014-03-20 13:19:09 UTC) #5

Message was sent while issue was closed.

Change committed as 169654

Expand Messages | Collapse Messages