Source/devtools/front_end/JSHeapSnapshot.js - Issue 206393004: Remove HeapSnapshotItemIterator.rewind

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/JSHeapSnapshot.js

Issue 206393004: Remove HeapSnapshotItemIterator.rewind (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/devtools/front_end/JSHeapSnapshot.js

diff --git a/Source/devtools/front_end/JSHeapSnapshot.js b/Source/devtools/front_end/JSHeapSnapshot.js

index 60ef492264eef55174919775ae697606323b2754..8a44638827320d538cabdaab7e121b71233b2c17 100644

--- a/Source/devtools/front_end/JSHeapSnapshot.js

+++ b/Source/devtools/front_end/JSHeapSnapshot.js

@@ -141,7 +141,7 @@ WebInspector.JSHeapSnapshot.prototype = {

if (globalObjEdge.isShortcut())

propNames[globalObjEdge._nameOrIndex()] = true;

}

- for (innerIter.rewind(); innerIter.hasNext(); innerIter.next()) {

+ for (var innerIter = node.edges(); innerIter.hasNext(); innerIter.next()) {

loislo 2014/03/20 13:16:40 The change is fine but looks like the code doesn't

yurys 2014/03/20 13:19:04 Yeah, I agree, let's remove it in a separate CL.

var globalObjEdge = innerIter.edge;

if (!globalObjEdge.isShortcut()

&& globalObjEdge.node().isHidden()

« no previous file with comments | « Source/devtools/front_end/HeapSnapshot.js ('k') | no next file » | no next file with comments »