Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2063913002: Fix gsubtreed to only include logs from modules that we care about. (Closed)

Created:
4 years, 6 months ago by iannucci
Modified:
4 years, 6 months ago
Reviewers:
martiniss
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Fix gsubtreed to only include logs from modules that we care about. R=martiniss@chromium.org BUG=619674 Committed: https://chromium.googlesource.com/infra/infra/+/a223224dfd81af6d41aa395df48f454b49278e15

Patch Set 1 #

Total comments: 2

Patch Set 2 : flaek #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -10 lines) Patch
M infra/services/gsubtreed/gsubtreed.py View 2 chunks +5 lines, -5 lines 0 comments Download
M infra/services/gsubtreed/test/gsubtreed_test.py View 1 3 chunks +15 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
iannucci
4 years, 6 months ago (2016-06-13 21:01:27 UTC) #1
martiniss
lgtm https://codereview.chromium.org/2063913002/diff/1/infra/services/gsubtreed/test/gsubtreed_test.py File infra/services/gsubtreed/test/gsubtreed_test.py (right): https://codereview.chromium.org/2063913002/diff/1/infra/services/gsubtreed/test/gsubtreed_test.py#newcode69 infra/services/gsubtreed/test/gsubtreed_test.py:69: # infra.libs.git2.repo logs this message if the command ...
4 years, 6 months ago (2016-06-13 21:30:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2063913002/1
4 years, 6 months ago (2016-06-13 21:30:46 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: Infra Mac Tester on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Infra%20Mac%20Tester/builds/2208)
4 years, 6 months ago (2016-06-13 21:44:07 UTC) #6
martiniss
https://codereview.chromium.org/2063913002/diff/1/infra/services/gsubtreed/test/gsubtreed_test.py File infra/services/gsubtreed/test/gsubtreed_test.py (right): https://codereview.chromium.org/2063913002/diff/1/infra/services/gsubtreed/test/gsubtreed_test.py#newcode71 infra/services/gsubtreed/test/gsubtreed_test.py:71: if (record.name.startswith('infra.libs.git2.repo.Repo') and need a pragma: no cover for ...
4 years, 6 months ago (2016-06-13 21:45:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2063913002/20001
4 years, 6 months ago (2016-06-13 22:08:19 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 22:45:38 UTC) #12
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/infra/infra/+/a223224dfd81af6d41aa395df48f4...

Powered by Google App Engine
This is Rietveld 408576698