Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: infra/services/gsubtreed/gsubtreed.py

Issue 2063913002: Fix gsubtreed to only include logs from modules that we care about. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: flaek Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | infra/services/gsubtreed/test/gsubtreed_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: infra/services/gsubtreed/gsubtreed.py
diff --git a/infra/services/gsubtreed/gsubtreed.py b/infra/services/gsubtreed/gsubtreed.py
index a83336cbef905b54cc8d4e2829069f5477edb670..805a1c718f1682faa6b7a2a4f286fae6b6af5a7b 100644
--- a/infra/services/gsubtreed/gsubtreed.py
+++ b/infra/services/gsubtreed/gsubtreed.py
@@ -102,7 +102,7 @@ class Pusher(threading.Thread):
self.join()
if self.FAKE_THREADING: # pragma: no cover
self._push()
- log = logging.info if self._success else logging.error
+ log = LOGGER.info if self._success else LOGGER.error
prefix = 'Completed' if self._success else 'FAILED'
log('%s push for %r', prefix, self._name)
if self._output:
@@ -162,21 +162,21 @@ def process_path(path, origin_repo, config):
if synth_parent is not INVALID:
f = synth_parent.data.footers
if MIRRORED_COMMIT not in f:
- logging.warn('Getting data from extra_footers. This information is'
+ LOGGER.warn('Getting data from extra_footers. This information is'
'only as trustworthy as the ACLs.')
f = synth_parent.extra_footers()
if MIRRORED_COMMIT not in f:
success = False
- logging.error('Could not find footers for synthesized commit %r',
+ LOGGER.error('Could not find footers for synthesized commit %r',
synth_parent.hsh)
continue
processed_commit = f[MIRRORED_COMMIT][0]
processed = origin_repo.get_commit(processed_commit)
- logging.info('got processed commit %s: %r', processed_commit, processed)
+ LOGGER.info('got processed commit %s: %r', processed_commit, processed)
if processed is INVALID:
success = False
- logging.error('Subtree mirror commit %r claims to mirror commit %r, '
+ LOGGER.error('Subtree mirror commit %r claims to mirror commit %r, '
'which doesn\'t exist in the origin repo. Halting.',
synth_parent.hsh, processed_commit)
continue
« no previous file with comments | « no previous file | infra/services/gsubtreed/test/gsubtreed_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698