Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 2063813002: mash: Move SystemTrayImage and TrayImageItem to //ash/common (Closed)

Created:
4 years, 6 months ago by James Cook
Modified:
4 years, 6 months ago
Reviewers:
msw
CC:
chromium-reviews, sadrul, dtseng+watch_chromium.org, derat+watch_chromium.org, aboxhall+watch_chromium.org, tfarina, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, kalyank, stevenjb+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@wmnotifier
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Move SystemTrayImage and TrayImageItem to //ash/common These are dependencies of TrayUpdate, which I am moving to //ash/common I'm allowing //ash/system/tray/system_tray.h in DEPS because it's mostly a bag of pointers to individual tray items. We'll be able to move it over once most of the individual items move and it doesn't seem worth the code churn to add a WmSystemTray. move_source_file.py ash/system/tray/tray_utils.h ash/common/system/tray/ move_source_file.py ash/system/tray/tray_utils.cc ash/common/system/tray/ move_source_file.py ash/system/tray/system_tray_item.h ash/common/system/tray/ move_source_file.py ash/system/tray/system_tray_item.cc ash/common/system/tray/ move_source_file.py ash/system/tray/tray_item_view.h ash/common/system/tray/ move_source_file.py ash/system/tray/tray_item_view.cc ash/common/system/tray/ move_source_file.py ash/system/tray/tray_image_item.h ash/common/system/tray/ move_source_file.py ash/system/tray/tray_image_item.cc ash/common/system/tray/ BUG=619636 TEST=compiles, ash_unittests Committed: https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e Cr-Commit-Position: refs/heads/master@{#399503}

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -782 lines) Patch
M ash/ash.gyp View 4 chunks +8 lines, -8 lines 0 comments Download
A ash/common/system/tray/DEPS View 1 chunk +6 lines, -0 lines 2 comments Download
A + ash/common/system/tray/system_tray_item.h View 2 chunks +4 lines, -5 lines 0 comments Download
A + ash/common/system/tray/system_tray_item.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ash/common/system/tray/tray_image_item.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + ash/common/system/tray/tray_image_item.cc View 1 chunk +3 lines, -4 lines 0 comments Download
A + ash/common/system/tray/tray_item_view.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/common/system/tray/tray_item_view.cc View 1 chunk +2 lines, -3 lines 0 comments Download
A + ash/common/system/tray/tray_utils.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/common/system/tray/tray_utils.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M ash/shelf/shelf_layout_manager_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/system/audio/tray_audio.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/audio/volume_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/cast/tray_cast.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/cast/tray_cast.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/system/chromeos/bluetooth/tray_bluetooth.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/brightness/tray_brightness.h View 1 chunk +1 line, -2 lines 0 comments Download
M ash/system/chromeos/brightness/tray_brightness_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/enterprise/tray_enterprise.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/network/tray_network.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/network/tray_network.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/system/chromeos/network/tray_sms.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/network/tray_sms.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/system/chromeos/network/tray_vpn.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/power/tray_power.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/power/tray_power.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/rotation/tray_rotation_lock.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/screen_security/screen_tray_item.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/chromeos/screen_security/screen_tray_item_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/session/logout_button_tray.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/session/tray_session_length_limit.h View 1 chunk +1 line, -2 lines 0 comments Download
M ash/system/chromeos/settings/tray_settings.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/supervised/tray_supervised_user.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/tray_caps_lock.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/tray_display.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/tray_tracing.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/date/date_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/date/tray_date.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/date/tray_date.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/ime/tray_ime_chromeos.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/ime/tray_ime_chromeos.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/system/overview/overview_button_tray.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/media_security/multi_profile_media_tray_item.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/media_security/multi_profile_media_tray_item.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/media_security/multi_profile_media_tray_item_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/system_tray.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/system/tray/system_tray_bubble.cc View 1 chunk +1 line, -1 line 0 comments Download
D ash/system/tray/system_tray_item.h View 1 chunk +0 lines, -121 lines 0 comments Download
D ash/system/tray/system_tray_item.cc View 1 chunk +0 lines, -87 lines 0 comments Download
M ash/system/tray/system_tray_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/system/tray/tray_details_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/tray_details_view_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/system/tray/tray_empty.h View 1 chunk +1 line, -1 line 0 comments Download
D ash/system/tray/tray_image_item.h View 1 chunk +0 lines, -54 lines 0 comments Download
D ash/system/tray/tray_image_item.cc View 1 chunk +0 lines, -84 lines 0 comments Download
M ash/system/tray/tray_item_more.cc View 1 chunk +1 line, -1 line 0 comments Download
D ash/system/tray/tray_item_view.h View 1 chunk +0 lines, -84 lines 0 comments Download
D ash/system/tray/tray_item_view.cc View 1 chunk +0 lines, -138 lines 0 comments Download
M ash/system/tray/tray_notification_view.cc View 1 chunk +1 line, -1 line 0 comments Download
D ash/system/tray/tray_utils.h View 1 chunk +0 lines, -41 lines 0 comments Download
D ash/system/tray/tray_utils.cc View 1 chunk +0 lines, -77 lines 0 comments Download
M ash/system/tray_accessibility.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray_update.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/user/button_from_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/user/tray_user.h View 1 chunk +1 line, -2 lines 0 comments Download
M ash/system/user/tray_user.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/user/tray_user_separator.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/user/user_card_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/web_notification/web_notification_tray.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/system/web_notification/web_notification_tray_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/system_tray_tray_cast_browsertest_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/message_center/web_notification_tray_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (3 generated)
James Cook
msw, please take a look.
4 years, 6 months ago (2016-06-13 17:53:34 UTC) #2
msw
lgtm with a tangential nit https://codereview.chromium.org/2063813002/diff/20001/ash/common/system/tray/DEPS File ash/common/system/tray/DEPS (right): https://codereview.chromium.org/2063813002/diff/20001/ash/common/system/tray/DEPS#newcode5 ash/common/system/tray/DEPS:5: "+ash/system/tray/system_tray.h", optional nit: this ...
4 years, 6 months ago (2016-06-13 18:43:38 UTC) #3
James Cook
https://codereview.chromium.org/2063813002/diff/20001/ash/common/system/tray/DEPS File ash/common/system/tray/DEPS (right): https://codereview.chromium.org/2063813002/diff/20001/ash/common/system/tray/DEPS#newcode5 ash/common/system/tray/DEPS:5: "+ash/system/tray/system_tray.h", On 2016/06/13 18:43:37, msw wrote: > optional nit: ...
4 years, 6 months ago (2016-06-13 19:04:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2063813002/20001
4 years, 6 months ago (2016-06-13 19:05:06 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-13 19:11:38 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-13 19:12:01 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 19:12:59 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e
Cr-Commit-Position: refs/heads/master@{#399503}

Powered by Google App Engine
This is Rietveld 408576698