Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 2061823002: mash: Move ash constants and layout constants files to //ash/common (Closed)

Created:
4 years, 6 months ago by James Cook
Modified:
4 years, 6 months ago
Reviewers:
msw
CC:
chromium-reviews, sadrul, tfarina, dzhioev+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, kalyank, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@trayimageitem
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Move ash constants and layout constants files to //ash/common These are dependencies of some of the system tray code that I'm moving to //ash/common. * Removed some unneeded includes * move_source_file.py ash/ash_constants.h ash/common/ * move_source_file.py ash/ash_constants.cc ash/common/ * move_source_file.py ash/ash_layout_constants.h ash/common/ * move_source_file.py ash/ash_layout_constants.cc ash/common/ BUG=619636 TEST=compiles, ash_unittests TBR=stevenjb@chromium.org for mechanical change to chrome/browser/chromeos Committed: https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba Cr-Commit-Position: refs/heads/master@{#399531}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -173 lines) Patch
M ash/ash.gyp View 2 chunks +4 lines, -4 lines 0 comments Download
D ash/ash_constants.h View 1 chunk +0 lines, -42 lines 0 comments Download
D ash/ash_constants.cc View 1 chunk +0 lines, -25 lines 0 comments Download
D ash/ash_layout_constants.h View 1 chunk +0 lines, -24 lines 0 comments Download
D ash/ash_layout_constants.cc View 1 chunk +0 lines, -36 lines 0 comments Download
M ash/aura/wm_window_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ash/common/ash_constants.h View 2 chunks +3 lines, -5 lines 0 comments Download
A + ash/common/ash_constants.cc View 1 chunk +1 line, -2 lines 0 comments Download
A + ash/common/ash_layout_constants.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/common/ash_layout_constants.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/frame/caption_buttons/frame_caption_button_container_view_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/frame/caption_buttons/frame_size_button_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/frame/custom_frame_view_ash_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/frame/default_header_painter.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/frame/frame_border_hit_test_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/root_window_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/app_list_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/overflow_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/audio/tray_audio.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/audio/volume_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/brightness/tray_brightness.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/network/network_state_list_detailed_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/actionable_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/tray_popup_header_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/tray_popup_label_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/user/button_from_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/immersive_fullscreen_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/resize_handle_window_targeter.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/resize_shadow_and_cursor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/window_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/multi_window_resize_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_test_utils.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_header_painter_ash.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (6 generated)
James Cook
msw, please take a look
4 years, 6 months ago (2016-06-13 18:22:16 UTC) #2
msw
lgtm
4 years, 6 months ago (2016-06-13 19:22:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2061823002/20001
4 years, 6 months ago (2016-06-13 20:08:40 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-13 20:56:36 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 20:57:43 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba
Cr-Commit-Position: refs/heads/master@{#399531}

Powered by Google App Engine
This is Rietveld 408576698