Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 2063653003: LowerCall for MIPS32 (Closed)

Created:
4 years, 6 months ago by mohit.bhakkad
Modified:
4 years, 6 months ago
CC:
native-client-reviews_googlegroups.com, jaydeep.patil, rich.fuhler_imgtec.com, srdjan.obucina_imgtec.com, sagar.thakur
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Removing conflict #

Total comments: 3

Patch Set 3 : Addressed review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -5 lines) Patch
M src/IceTargetLoweringMIPS32.cpp View 1 2 4 chunks +93 lines, -5 lines 0 comments Download
A tests_lit/llvm2ice_tests/callArgs.ll View 1 chunk +54 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
mohit.bhakkad
With this patch 64bit.pnacl.ll still fails due to liveliness error, but uploading it, as this ...
4 years, 6 months ago (2016-06-13 10:42:22 UTC) #2
mohit.bhakkad
4 years, 6 months ago (2016-06-13 11:31:51 UTC) #3
Jim Stichnoth
On 2016/06/13 10:42:22, mohit.bhakkad wrote: > With this patch 64bit.pnacl.ll still fails due to liveliness ...
4 years, 6 months ago (2016-06-13 13:28:58 UTC) #4
mohit.bhakkad
On 2016/06/13 13:28:58, stichnot wrote: > On 2016/06/13 10:42:22, mohit.bhakkad wrote: > > With this ...
4 years, 6 months ago (2016-06-21 08:53:54 UTC) #5
Jim Stichnoth
On 2016/06/21 08:53:54, mohit.bhakkad wrote: > On 2016/06/13 13:28:58, stichnot wrote: > > On 2016/06/13 ...
4 years, 6 months ago (2016-06-21 13:22:23 UTC) #6
Jim Stichnoth
https://codereview.chromium.org/2063653003/diff/20001/src/IceTargetLoweringMIPS32.cpp File src/IceTargetLoweringMIPS32.cpp (right): https://codereview.chromium.org/2063653003/diff/20001/src/IceTargetLoweringMIPS32.cpp#newcode225 src/IceTargetLoweringMIPS32.cpp:225: assert(Func->validateLiveness()); I recommend moving this assert (and its two ...
4 years, 6 months ago (2016-06-21 13:44:00 UTC) #7
Jim Stichnoth
https://codereview.chromium.org/2063653003/diff/20001/src/IceTargetLoweringMIPS32.cpp File src/IceTargetLoweringMIPS32.cpp (right): https://codereview.chromium.org/2063653003/diff/20001/src/IceTargetLoweringMIPS32.cpp#newcode225 src/IceTargetLoweringMIPS32.cpp:225: assert(Func->validateLiveness()); On 2016/06/21 13:44:00, stichnot wrote: > I recommend ...
4 years, 6 months ago (2016-06-21 13:46:17 UTC) #8
mohit.bhakkad
Thanks Jim for the help, I have moved the assertion location for liveliness in https://codereview.chromium.org/2080633004, ...
4 years, 6 months ago (2016-06-22 10:07:46 UTC) #9
Jim Stichnoth
lgtm
4 years, 6 months ago (2016-06-22 12:38:31 UTC) #10
Jim Stichnoth
4 years, 6 months ago (2016-06-22 12:44:12 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
9b4c3c3a41bfb8e9643109d47e8dd26c7f33ba8e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698