Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2063603002:
Fix unsafe handling of part object in RuleFeatureSetTest. (Closed)
|
Created:
4 years, 6 months ago by sof Modified:
4 years, 6 months ago CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix unsafe handling of part object in RuleFeatureSetTest.
The part object needs to be traced; the ad-hoc and unused
trace method used prevented GC plugin detection.
R=
BUG=
NOTRY=true
Committed: https://crrev.com/b7f840f2f7ebd60d6493fcac581551c8d6ae3255
Cr-Commit-Position: refs/heads/master@{#399416}
Patch Set 1 #
Dependent Patchsets: Messages
Total messages: 27 (13 generated)
sigbjornf@opera.com changed reviewers: + oilpan-reviews@chromium.org
please take a look.
LGTM
The CQ bit was checked by sigbjornf@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2063603002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by sigbjornf@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2063603002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by sigbjornf@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2063603002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by sigbjornf@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2063603002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Description was changed from ========== Fix unsafe handling of part object in RuleFeatureSetTest. The part object needs to be traced; the ad-hoc and unused trace method used prevented GC plugin detection. R= BUG= ========== to ========== Fix unsafe handling of part object in RuleFeatureSetTest. The part object needs to be traced; the ad-hoc and unused trace method used prevented GC plugin detection. R= BUG= NOTRY=true ==========
The CQ bit was checked by sigbjornf@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2063603002/1
Message was sent while issue was closed.
Description was changed from ========== Fix unsafe handling of part object in RuleFeatureSetTest. The part object needs to be traced; the ad-hoc and unused trace method used prevented GC plugin detection. R= BUG= NOTRY=true ========== to ========== Fix unsafe handling of part object in RuleFeatureSetTest. The part object needs to be traced; the ad-hoc and unused trace method used prevented GC plugin detection. R= BUG= NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
CQ bit was unchecked
Message was sent while issue was closed.
Description was changed from ========== Fix unsafe handling of part object in RuleFeatureSetTest. The part object needs to be traced; the ad-hoc and unused trace method used prevented GC plugin detection. R= BUG= NOTRY=true ========== to ========== Fix unsafe handling of part object in RuleFeatureSetTest. The part object needs to be traced; the ad-hoc and unused trace method used prevented GC plugin detection. R= BUG= NOTRY=true Committed: https://crrev.com/b7f840f2f7ebd60d6493fcac581551c8d6ae3255 Cr-Commit-Position: refs/heads/master@{#399416} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/b7f840f2f7ebd60d6493fcac581551c8d6ae3255 Cr-Commit-Position: refs/heads/master@{#399416} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
