Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 2060683002: Make trace() over persistents private. (Closed)

Created:
4 years, 6 months ago by sof
Modified:
4 years, 6 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews, kouhei+heap_chromium.org, oilpan-reviews, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/src.git@sof-fix-unit-css
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make trace() over persistents private. Persistent references register a trace callback with the underlying persistent node, allowing the Blink GC to trace the persistent root set when marking. Consequently, there's no need to expose their trace() methods as public methods. Make them private and thereby disallow calling trace() from Blink code. R= BUG= Committed: https://crrev.com/047902223d816789a303b50ae21332668d85d6ed Cr-Commit-Position: refs/heads/master@{#399423}

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -21 lines) Patch
M third_party/WebKit/Source/platform/heap/Persistent.h View 6 chunks +21 lines, -21 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
sof
please take a look.
4 years, 6 months ago (2016-06-12 07:03:03 UTC) #2
haraken
LGTM
4 years, 6 months ago (2016-06-12 07:05:34 UTC) #3
commit-bot: I haz the power
This CL has an open dependency (Issue 2063603002 Patch 1). Please resolve the dependency and ...
4 years, 6 months ago (2016-06-12 14:31:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2060683002/40001
4 years, 6 months ago (2016-06-13 08:49:14 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-13 10:31:09 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 10:32:21 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/047902223d816789a303b50ae21332668d85d6ed
Cr-Commit-Position: refs/heads/master@{#399423}

Powered by Google App Engine
This is Rietveld 408576698