Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 2063573002: Don't invalidate Inlinebox being deleted (Closed)

Created:
4 years, 6 months ago by Xianzhu
Modified:
4 years, 6 months ago
Reviewers:
chrishtr, pdr.
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't invalidate Inlineboxes being deleted Invalidation of InlineBoxes being deleted was needed when we used a hash map in PaintController to track paint invalidations, to ensure a new object allocated at the same address of an deleted but not invalidated object won't be mistakenly treated as cached. Now this is unnecessary with client-side cache generations. BUG=619630 R=chrishtr@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/4caf53fcb47c4df2bc26a3b0df8f366a3f4352f7

Patch Set 1 #

Patch Set 2 : Try not to invalidate Inlinebox when destroyed #

Patch Set 3 : NeedsRebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -8 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 4 chunks +129 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineBox.cpp View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
Xianzhu
4 years, 6 months ago (2016-06-15 20:39:50 UTC) #3
chrishtr
lgtm
4 years, 6 months ago (2016-06-16 05:00:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2063573002/20001
4 years, 6 months ago (2016-06-16 05:00:28 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/247404) win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, ...
4 years, 6 months ago (2016-06-16 06:16:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2063573002/40001
4 years, 6 months ago (2016-06-18 03:38:32 UTC) #11
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/4caf53fcb47c4df2bc26a3b0df8f366a3f4352f7 Cr-Commit-Position: refs/heads/master@{#400580}
4 years, 6 months ago (2016-06-18 05:57:28 UTC) #14
Xianzhu
4 years, 6 months ago (2016-06-18 05:59:32 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
4caf53fcb47c4df2bc26a3b0df8f366a3f4352f7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698