Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Side by Side Diff: third_party/WebKit/Source/core/layout/line/InlineBox.cpp

Issue 2063573002: Don't invalidate Inlinebox being deleted (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: NeedsRebaseline Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003, 2004, 2005, 2006, 2007 Apple Inc. All rights reserved. 2 * Copyright (C) 2003, 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
3 * 3 *
4 * This library is free software; you can redistribute it and/or 4 * This library is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU Library General Public 5 * modify it under the terms of the GNU Library General Public
6 * License as published by the Free Software Foundation; either 6 * License as published by the Free Software Foundation; either
7 * version 2 of the License, or (at your option) any later version. 7 * version 2 of the License, or (at your option) any later version.
8 * 8 *
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 InlineBox::~InlineBox() 56 InlineBox::~InlineBox()
57 { 57 {
58 if (!m_hasBadParent && m_parent) 58 if (!m_hasBadParent && m_parent)
59 m_parent->setHasBadChildList(); 59 m_parent->setHasBadChildList();
60 } 60 }
61 61
62 #endif 62 #endif
63 63
64 void InlineBox::destroy() 64 void InlineBox::destroy()
65 { 65 {
66 // We do not need to issue invalidations if the page is being destroyed
67 // since these objects will never be repainted.
68 if (!m_lineLayoutItem.documentBeingDestroyed())
69 m_lineLayoutItem.invalidateDisplayItemClient(*this);
70 delete this; 66 delete this;
71 } 67 }
72 68
73 void InlineBox::remove(MarkLineBoxes markLineBoxes) 69 void InlineBox::remove(MarkLineBoxes markLineBoxes)
74 { 70 {
75 if (parent()) 71 if (parent())
76 parent()->removeChild(this, markLineBoxes); 72 parent()->removeChild(this, markLineBoxes);
77 } 73 }
78 74
79 void* InlineBox::operator new(size_t sz) 75 void* InlineBox::operator new(size_t sz)
(...skipping 325 matching lines...) Expand 10 before | Expand all | Expand 10 after
405 401
406 void showLineTree(const blink::InlineBox* b) 402 void showLineTree(const blink::InlineBox* b)
407 { 403 {
408 if (b) 404 if (b)
409 b->showLineTreeForThis(); 405 b->showLineTreeForThis();
410 else 406 else
411 fprintf(stderr, "Cannot showLineTree for (nil) InlineBox.\n"); 407 fprintf(stderr, "Cannot showLineTree for (nil) InlineBox.\n");
412 } 408 }
413 409
414 #endif 410 #endif
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698