device/bluetooth: split out transport enum

device/bluetooth: split out transport enum

The transport enum can be reused to describe supported transport
types for remote devices and adapters. As such, move it out in
preparation for adding this functionality to transports and
adapters.

BUG=b:29268565
TEST=compile and run unit tests

Committed: https://crrev.com/ee39a56de7e2646b3e37b9efddfc9fe0be5194ab
Cr-Commit-Position: refs/heads/master@{#400798}

[Eric Caruso, 2016-06-15 00:20:47]

Description was changed from

==========
device/bluetooth: split out transport enum

The transport enum can be reused to describe supported transport
types for remote devices and adapters. As such, move it out in
preparation for adding this functionality to transports and
adapters.

BUG=b:29268565
TEST=compile and run unit tests
==========

to

==========
device/bluetooth: split out transport enum

The transport enum can be reused to describe supported transport
types for remote devices and adapters. As such, move it out in
preparation for adding this functionality to transports and
adapters.

BUG=b:29268565
TEST=compile and run unit tests
==========

[Eric Caruso, 2016-06-15 00:20:47]

ejcaruso@chromium.org changed reviewers:
+ jam@chromium.org, ortuno@chromium.org

[jam, 2016-06-15 17:53:28]

components & content lgtm

[ortuno, 2016-06-15 18:12:27]

https://codereview.chromium.org/2063353002/diff/60001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_types.h (right):

https://codereview.chromium.org/2063353002/diff/60001/device/bluetooth/blueto...
device/bluetooth/bluetooth_types.h:5: #ifndef
DEVICE_BLUETOOTH_BLUETOOTH_TYPES_H_
optional: IMHO bluetooth_common.h would be better.

https://codereview.chromium.org/2063353002/diff/60001/device/bluetooth/blueto...
device/bluetooth/bluetooth_types.h:11: 
Add a comment about what goes in this file.

https://codereview.chromium.org/2063353002/diff/60001/device/bluetooth/blueto...
device/bluetooth/bluetooth_types.h:12: enum DEVICE_BLUETOOTH_EXPORT
BluetoothTransport {
Make this an enum class and remove the TRANSPORT prefix from the enums. Also add
a comment explaining what this is used for.

[ortuno, 2016-06-15 18:13:34]

https://codereview.chromium.org/2063353002/diff/60001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_discovery_filter.h (right):

https://codereview.chromium.org/2063353002/diff/60001/device/bluetooth/blueto...
device/bluetooth/bluetooth_discovery_filter.h:24: // Allowed transport types for
the scan filter.
I don't think this comment belongs here anymore.

[Eric Caruso, 2016-06-15 22:32:09]

ejcaruso@chromium.org changed reviewers:
+ stevenjb@chromium.org

[Eric Caruso, 2016-06-15 22:32:10]

+stevenjb for extensions/browser/api/bluetooth.

PTAL.

https://codereview.chromium.org/2063353002/diff/80001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_common.h (right):

https://codereview.chromium.org/2063353002/diff/80001/device/bluetooth/blueto...
device/bluetooth/bluetooth_common.h:18: enum BluetoothTransport : uint8_t {
As per offline discussion with ortuno@, using enum class here would prevent us
from neatly manipulating the transport values like a bitset. I proposed going
back to a regular unscoped enum or using a std::bitset and we chose to go with
the former.

Because of this, I changed the names of the values to be a little more in line
with the style of unscoped enums.

[Eric Caruso, 2016-06-15 22:40:11]

Whoops, it didn't compile everything when I tried it locally. PTAL.

[ortuno, 2016-06-15 23:09:31]

lgtm

https://codereview.chromium.org/2063353002/diff/80001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_discovery_filter.cc (right):

https://codereview.chromium.org/2063353002/diff/80001/device/bluetooth/blueto...
device/bluetooth/bluetooth_discovery_filter.cc:119:
result->SetTransport(static_cast<BluetoothTransport>(filter_a->transport_ |
Why do you need this static_cast?

[ortuno, 2016-06-15 23:10:03]

On 2016/06/15 at 23:09:31, ortuno wrote:
> lgtm
> 
>
https://codereview.chromium.org/2063353002/diff/80001/device/bluetooth/blueto...
> File device/bluetooth/bluetooth_discovery_filter.cc (right):
> 
>
https://codereview.chromium.org/2063353002/diff/80001/device/bluetooth/blueto...
> device/bluetooth/bluetooth_discovery_filter.cc:119:
result->SetTransport(static_cast<BluetoothTransport>(filter_a->transport_ |
> Why do you need this static_cast?

Ignore that comment :) Left over from previous reviews.

[stevenjb, 2016-06-20 17:26:50]

lgtm

[Eric Caruso, 2016-06-20 18:18:11]

The CQ bit was checked by ejcaruso@chromium.org

[Eric Caruso, 2016-06-20 18:18:12]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org,
ortuno@chromium.org
Link to the patchset: https://codereview.chromium.org/2063353002/#ps160001
(title: "fixing new use in components/arc/bluetooth")

[commit-bot: I haz the power, 2016-06-20 18:18:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-20 18:18:40]

This CL has an open dependency (Issue 2073273002 Patch 1). Please resolve the
dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[Eric Caruso, 2016-06-20 18:19:28]

The CQ bit was checked by ejcaruso@chromium.org

[commit-bot: I haz the power, 2016-06-20 18:19:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-20 18:19:52]

This CL has an open dependency (Issue 2073273002 Patch 1). Please resolve the
dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[Eric Caruso, 2016-06-20 20:09:03]

The CQ bit was checked by ejcaruso@chromium.org

[commit-bot: I haz the power, 2016-06-20 20:09:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2063353002/160001

[commit-bot: I haz the power, 2016-06-20 21:48:02]

Description was changed from

==========
device/bluetooth: split out transport enum

The transport enum can be reused to describe supported transport
types for remote devices and adapters. As such, move it out in
preparation for adding this functionality to transports and
adapters.

BUG=b:29268565
TEST=compile and run unit tests
==========

to

==========
device/bluetooth: split out transport enum

The transport enum can be reused to describe supported transport
types for remote devices and adapters. As such, move it out in
preparation for adding this functionality to transports and
adapters.

BUG=b:29268565
TEST=compile and run unit tests
==========

[commit-bot: I haz the power, 2016-06-20 21:48:03]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-06-20 21:58:29]

Description was changed from

==========
device/bluetooth: split out transport enum

The transport enum can be reused to describe supported transport
types for remote devices and adapters. As such, move it out in
preparation for adding this functionality to transports and
adapters.

BUG=b:29268565
TEST=compile and run unit tests
==========

to

==========
device/bluetooth: split out transport enum

The transport enum can be reused to describe supported transport
types for remote devices and adapters. As such, move it out in
preparation for adding this functionality to transports and
adapters.

BUG=b:29268565
TEST=compile and run unit tests

Committed: https://crrev.com/ee39a56de7e2646b3e37b9efddfc9fe0be5194ab
Cr-Commit-Position: refs/heads/master@{#400798}
==========

[commit-bot: I haz the power, 2016-06-20 21:58:30]

Patchset 9 (id:??) landed as
https://crrev.com/ee39a56de7e2646b3e37b9efddfc9fe0be5194ab
Cr-Commit-Position: refs/heads/master@{#400798}