device/bluetooth/bluetooth_types.h - Issue 2063353002: device/bluetooth: split out transport enum

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: device/bluetooth/bluetooth_types.h

Issue 2063353002: device/bluetooth: split out transport enum (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: renaming header, moving TransportMask back into filter Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef DEVICE_BLUETOOTH_BLUETOOTH_TYPES_H_
	ortuno 2016/06/15 18:12:27 optional: IMHO bluetooth_common.h would be better. optional: IMHO bluetooth_common.h would be better.
	6 #define DEVICE_BLUETOOTH_BLUETOOTH_TYPES_H_

	7

	8 #include "device/bluetooth/bluetooth_export.h"

	9

	10 namespace device {

	11
	ortuno 2016/06/15 18:12:27 Add a comment about what goes in this file. Add a comment about what goes in this file.
	12 enum DEVICE_BLUETOOTH_EXPORT BluetoothTransport {
	ortuno 2016/06/15 18:12:27 Make this an enum class and remove the TRANSPORT p Make this an enum class and remove the TRANSPORT prefix from the enums. Also add a comment explaining what this is used for.
	13 TRANSPORT_INVALID = 0x00,

	14 // Valid transports are given as a bitset.

	15 TRANSPORT_CLASSIC = 0x01,

	16 TRANSPORT_LE = 0x02,

	17 TRANSPORT_DUAL = (TRANSPORT_CLASSIC \| TRANSPORT_LE)

	18 };

	19

	20 } // namespace device

	21

	22 #endif // DEVICE_BLUETOOTH_BLUETOOTH_TYPES_H_

OLD	NEW