Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 2063333002: mash: Move all ash UMA metrics to //ash/common/metrics (Closed)

Created:
4 years, 6 months ago by James Cook
Modified:
4 years, 6 months ago
Reviewers:
msw
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Move all ash UMA metrics to //ash/common/metrics Now that the window manager and sysui are the same binary we don't need to maintain separate UserMetricsAction and WmUserMetricsAction enums. Also remove some unnecessary ash:: namespace qualifiers. BUG=619636 TEST=compiles, ash_unittests Committed: https://crrev.com/a96777c4353060e81cbe657ca6c1e2490d776ed5 Cr-Commit-Position: refs/heads/master@{#399820}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -379 lines) Patch
M ash/ash.gyp View 2 chunks +1 line, -1 line 0 comments Download
M ash/aura/wm_shell_aura.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/aura/wm_shell_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ash/common/metrics/user_metrics_action.h View 5 chunks +20 lines, -79 lines 0 comments Download
M ash/common/shelf/shelf_alignment_menu.cc View 2 chunks +4 lines, -7 lines 0 comments Download
D ash/common/wm/wm_user_metrics_action.h View 1 chunk +0 lines, -35 lines 0 comments Download
M ash/common/wm/workspace/workspace_window_resizer.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M ash/common/wm_shell.h View 3 chunks +2 lines, -4 lines 0 comments Download
M ash/metrics/user_metrics_recorder.h View 3 chunks +2 lines, -108 lines 0 comments Download
M ash/metrics/user_metrics_recorder.cc View 3 chunks +120 lines, -127 lines 0 comments Download
M ash/mus/bridge/wm_shell_mus.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/mus/bridge/wm_shell_mus.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/date/date_default_view.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ash/wm/overview/window_selector.cc View 4 chunks +4 lines, -5 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (6 generated)
James Cook
msw, please take a look.
4 years, 6 months ago (2016-06-14 22:14:27 UTC) #3
msw
lgtm
4 years, 6 months ago (2016-06-14 22:35:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2063333002/1
4 years, 6 months ago (2016-06-14 22:36:47 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) ios-device-gn on ...
4 years, 6 months ago (2016-06-15 00:14:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2063333002/1
4 years, 6 months ago (2016-06-15 00:51:05 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-15 02:15:45 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-15 02:15:48 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 02:17:13 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a96777c4353060e81cbe657ca6c1e2490d776ed5
Cr-Commit-Position: refs/heads/master@{#399820}

Powered by Google App Engine
This is Rietveld 408576698