mash: Move //ash/system/date to //ash/common

mash: Move //ash/system/date to //ash/common

It no longer has aura or ash::Shell dependencies.

Moved chromeos-specific dependencies to //ash/common/system/chromeos and
copied //ash/system/chromeos/DEPS there.

BUG=619636
TEST=compiles, ash_unittests

Committed: https://crrev.com/090562764026b47fe5abb09fd89670123b63e0cb
Cr-Commit-Position: refs/heads/master@{#400059}

[James Cook, 2016-06-14 22:36:03]

jamescook@chromium.org changed reviewers:
+ msw@chromium.org

[James Cook, 2016-06-14 22:36:04]

msw, can I get a rubber-stamp for this mechanical move?  The only other changes
are fixing a missing include, removing an unnecessary ash::, and copying the
DEPS file.

[msw, 2016-06-14 23:11:43]

lgtm with nits

https://codereview.chromium.org/2061123004/diff/1/ash/ash.gyp
File ash/ash.gyp (right):

https://codereview.chromium.org/2061123004/diff/1/ash/ash.gyp#newcode97
ash/ash.gyp:97: 'common/system/chromeos/system_clock_observer.cc',
Add shutdown_policy_observer.h, not previously listed...

https://codereview.chromium.org/2061123004/diff/1/ash/common/system/chromeos/...
File ash/common/system/chromeos/DEPS (right):

https://codereview.chromium.org/2061123004/diff/1/ash/common/system/chromeos/...
ash/common/system/chromeos/DEPS:2: "+chromeos",
Nice, src/chromeos doesn't use aura! I suppose this dep is ok.

https://codereview.chromium.org/2061123004/diff/1/ash/common/system/chromeos/...
ash/common/system/chromeos/DEPS:3: "+grit/ui_chromeos_resources.h",
nit: these grit DEPS aren't used yet; delay adding until needed?

[James Cook, 2016-06-14 23:23:35]

Patchset #3 (id:40001) has been deleted

[James Cook, 2016-06-14 23:24:21]

https://codereview.chromium.org/2061123004/diff/1/ash/ash.gyp
File ash/ash.gyp (right):

https://codereview.chromium.org/2061123004/diff/1/ash/ash.gyp#newcode97
ash/ash.gyp:97: 'common/system/chromeos/system_clock_observer.cc',
On 2016/06/14 23:11:42, msw wrote:
> Add shutdown_policy_observer.h, not previously listed...

Done.

https://codereview.chromium.org/2061123004/diff/1/ash/common/system/chromeos/...
File ash/common/system/chromeos/DEPS (right):

https://codereview.chromium.org/2061123004/diff/1/ash/common/system/chromeos/...
ash/common/system/chromeos/DEPS:2: "+chromeos",
On 2016/06/14 23:11:42, msw wrote:
> Nice, src/chromeos doesn't use aura! I suppose this dep is ok.

Acknowledged.

https://codereview.chromium.org/2061123004/diff/1/ash/common/system/chromeos/...
ash/common/system/chromeos/DEPS:3: "+grit/ui_chromeos_resources.h",
On 2016/06/14 23:11:42, msw wrote:
> nit: these grit DEPS aren't used yet; delay adding until needed?

Done.

[James Cook, 2016-06-14 23:25:40]

jamescook@chromium.org changed reviewers:
+ stevenjb@chromium.org

[James Cook, 2016-06-14 23:25:41]

stevenjb, can I get OWNERS for +chromeos in //ash/common/system/chromeos/DEPS?
(This is a copy from //ash/system/chromeos/DEPS.)

[stevenjb, 2016-06-15 00:01:39]

lgtm

[James Cook, 2016-06-15 02:28:55]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-06-15 02:28:56]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org,
stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/2061123004/#ps40002
(title: "Rebase")

[commit-bot: I haz the power, 2016-06-15 02:29:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2061123004/40002

[commit-bot: I haz the power, 2016-06-15 03:10:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-15 03:10:17]

Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[James Cook, 2016-06-15 23:22:08]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-06-15 23:22:09]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org,
stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/2061123004/#ps90001
(title: "rebase again")

[commit-bot: I haz the power, 2016-06-15 23:22:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2061123004/90001

[commit-bot: I haz the power, 2016-06-16 00:28:56]

Committed patchset #5 (id:90001)

[commit-bot: I haz the power, 2016-06-16 00:28:58]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-16 00:30:14]

Description was changed from

==========
mash: Move //ash/system/date to //ash/common

It no longer has aura or ash::Shell dependencies.

Moved chromeos-specific dependencies to //ash/common/system/chromeos and
copied //ash/system/chromeos/DEPS there.

BUG=619636
TEST=compiles, ash_unittests
==========

to

==========
mash: Move //ash/system/date to //ash/common

It no longer has aura or ash::Shell dependencies.

Moved chromeos-specific dependencies to //ash/common/system/chromeos and
copied //ash/system/chromeos/DEPS there.

BUG=619636
TEST=compiles, ash_unittests

Committed: https://crrev.com/090562764026b47fe5abb09fd89670123b63e0cb
Cr-Commit-Position: refs/heads/master@{#400059}
==========

[commit-bot: I haz the power, 2016-06-16 00:30:15]

Patchset 5 (id:??) landed as
https://crrev.com/090562764026b47fe5abb09fd89670123b63e0cb
Cr-Commit-Position: refs/heads/master@{#400059}