media: Call SetMediaClientAndroid() in content for browser process

media: Call SetMediaClientAndroid() in content for browser process

Previously this is called in content embedders like chrome/cast/aw which
resulted in a lot of duplicate code.

BUG=619827
TEST=Manually tested and verified MediaClientAndroid is set.

Committed: https://crrev.com/12220eaf680404664a9b18982886f589f8a6b7de
Cr-Commit-Position: refs/heads/master@{#400323}

[xhwang, 2016-06-14 23:02:03]

xhwang@chromium.org changed reviewers:
+ boliu@chromium.org, halliwell@chromium.org, nasko@chromium.org,
thestig@chromium.org

[xhwang, 2016-06-14 23:02:04]

I touched 4 files and I need 4 OWNERS to review :)

This is basically what I promised to do in
https://codereview.chromium.org/1907263003. See the last part of the CL
description.

thestig@chromium.org: Please review changes in chrome/browser

boliu@chromium.org: Please review changes in webview

halliwell@chromium.org: Please review changes in chromecast

nasko@chromium.org: Please review changes in content

[halliwell, 2016-06-14 23:33:12]

On 2016/06/14 23:02:04, xhwang wrote:
> I touched 4 files and I need 4 OWNERS to review :)
> 
> This is basically what I promised to do in
> https://codereview.chromium.org/1907263003. See the last part of the CL
> description.
> 
> mailto:thestig@chromium.org: Please review changes in chrome/browser
> 
> mailto:boliu@chromium.org: Please review changes in webview
> 
> mailto:halliwell@chromium.org: Please review changes in chromecast
> 
> mailto:nasko@chromium.org: Please review changes in content

chromecast/ lgtm

[Lei Zhang, 2016-06-14 23:38:50]

https://chromiumcodereview.appspot.com/2063123002/diff/1/chrome/browser/chrom...
File chrome/browser/chrome_browser_main_android.cc (right):

https://chromiumcodereview.appspot.com/2063123002/diff/1/chrome/browser/chrom...
chrome/browser/chrome_browser_main_android.cc:120: void
ChromeBrowserMainPartsAndroid::PreMainMessageLoopRun() {
You can get rid of this altogether if all it's doing is calling its parent
class.

[boliu, 2016-06-14 23:58:53]

lgtm

[xhwang, 2016-06-15 00:31:52]

PTAL again

https://chromiumcodereview.appspot.com/2063123002/diff/1/chrome/browser/chrom...
File chrome/browser/chrome_browser_main_android.cc (right):

https://chromiumcodereview.appspot.com/2063123002/diff/1/chrome/browser/chrom...
chrome/browser/chrome_browser_main_android.cc:120: void
ChromeBrowserMainPartsAndroid::PreMainMessageLoopRun() {
On 2016/06/14 23:38:50, Lei Zhang wrote:
> You can get rid of this altogether if all it's doing is calling its parent
> class.

Done.

[xhwang, 2016-06-15 00:32:00]

The CQ bit was checked by xhwang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-15 00:32:42]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2063123002/20001

[Lei Zhang, 2016-06-15 00:35:05]

lgtm

[commit-bot: I haz the power, 2016-06-15 01:03:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-15 01:03:04]

Dry run: Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[xhwang, 2016-06-15 02:36:32]

nasko: The change in content is very trivial to review. PTAL

[xhwang, 2016-06-16 16:29:30]

xhwang@chromium.org changed reviewers:
+ jam@chromium.org

[xhwang, 2016-06-16 16:29:31]

It seems nasko is busy.

jam: Could you please OWNERS review a trivial change in
content/browser/browser_main_loop.cc? Thanks!

[jam, 2016-06-16 18:21:08]

lgtm

[xhwang, 2016-06-16 21:34:03]

The CQ bit was checked by xhwang@chromium.org

[xhwang, 2016-06-16 21:34:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
halliwell@chromium.org, boliu@chromium.org
Link to the patchset: https://codereview.chromium.org/2063123002/#ps20001
(title: "media: Call SetMediaClientAndroid() in content for browser process")

[commit-bot: I haz the power, 2016-06-16 21:35:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2063123002/20001

[commit-bot: I haz the power, 2016-06-17 00:57:52]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-17 00:59:52]

Description was changed from

==========
media: Call SetMediaClientAndroid() in content for browser process

Previously this is called in content embedders like chrome/cast/aw which
resulted in a lot of duplicate code.

BUG=619827
TEST=Manually tested and verified MediaClientAndroid is set.
==========

to

==========
media: Call SetMediaClientAndroid() in content for browser process

Previously this is called in content embedders like chrome/cast/aw which
resulted in a lot of duplicate code.

BUG=619827
TEST=Manually tested and verified MediaClientAndroid is set.

Committed: https://crrev.com/12220eaf680404664a9b18982886f589f8a6b7de
Cr-Commit-Position: refs/heads/master@{#400323}
==========

[commit-bot: I haz the power, 2016-06-17 00:59:55]

Patchset 2 (id:??) landed as
https://crrev.com/12220eaf680404664a9b18982886f589f8a6b7de
Cr-Commit-Position: refs/heads/master@{#400323}