media: Set MediaClientAndroid in the GPU process.

media: Set MediaClientAndroid in the GPU process.

Now on Android we use MediaDrmBridge in the GPU process. We should set
MediaClientAndroid the same as we do in the Browser process.

Summary of changes:
- Add ContentClient::GetMediaClientAndroid() API.
- SetMediaClientAndroid() in GPU process.

Today in the browser, we call media::SetMediaClientAndroid() directly
from content embedders (e.g. ChromeBrowserMainPartsAndroid), which
seems hacky. We should use ContentClient::GetMediaClientAndroid() in
the browser process as well so that content will talk to the embedder,
and then talk to media. I'll work on it after this CL.

TBR=slan@chromium.org
BUG=605330
TEST=Encrypted Widevine contents plays in the GPU process on Android K.

Committed: https://crrev.com/f258baab74abe43f7f77bdae8b74c61c07f95f51
Cr-Commit-Position: refs/heads/master@{#390517}

[xhwang, 2016-04-22 23:49:54]

Description was changed from

==========
media: Set MediaClientAndroid in the GPU process.

Now on Android we use MediaDrmBridge in the GPU process. We should set
MediaClientAndroid the same as we do in the Browser process.

BUG=605330
TEST=Encrypted Widevine contents plays in the GPU process on Android K.
==========

to

==========
media: Set MediaClientAndroid in the GPU process.

Now on Android we use MediaDrmBridge in the GPU process. We should set
MediaClientAndroid the same as we do in the Browser process.

Summary of changes:
- Add ContentClient::GetMediaClientAndroid() API.
- SetMediaClientAndroid() in GPU process.

Today in the browser, we call media::SetMediaClientAndroid() directly
from content embedders (e.g. ChromeBrowserMainPartsAndroid), which
seems hacky. We should use ContentClient::GetMediaClientAndroid() in
the browser process as well so that content will talk to the embedder,
and then talk to media. I'll work on it after this CL.

BUG=605330
TEST=Encrypted Widevine contents plays in the GPU process on Android K.
==========

[xhwang, 2016-04-22 23:49:54]

xhwang@chromium.org changed reviewers:
+ nasko@chromium.org

[xhwang, 2016-04-23 00:02:30]

nasko: PTAL

Please see the CL description for details. The existing code (in browser
process) has a lot of room for improvement. But I want to do that in a separate
CL because I need to merge this fix back to M51 to fix a real bug.

Mostly I am moving things around. I did add a content client API and use it in
the GPU process which is the real change.

https://chromiumcodereview.appspot.com/1907263003/diff/1/chrome/chrome_browse...
File chrome/chrome_browser.gypi (right):

https://chromiumcodereview.appspot.com/1907263003/diff/1/chrome/chrome_browse...
chrome/chrome_browser.gypi:500:
'browser/profiles/incognito_mode_policy_handler.cc',
These changes are legit but are noises to my CL. Do you want me to put them in a
separate CL?

[nasko, 2016-04-25 23:23:47]

content/ LGTM

[xhwang, 2016-04-25 23:34:45]

xhwang@chromium.org changed reviewers:
+ boliu@chromium.org, slan@chromium.org, thestig@chromium.org

[xhwang, 2016-04-25 23:34:46]

boliu@chromium.org: Please OWNERS review changes in webview

slan@chromium.org: Please OWNERS review changes in chromecast/

thestig@chromium.org: Please OWNERS review changes in chrome/

[boliu, 2016-04-25 23:38:28]

On 2016/04/25 23:34:46, xhwang wrote:
> mailto:boliu@chromium.org: Please OWNERS review changes in webview

rs lgtm

> 
> mailto:slan@chromium.org: Please OWNERS review changes in chromecast/
> 
> mailto:thestig@chromium.org: Please OWNERS review changes in chrome/

[Lei Zhang, 2016-04-26 00:02:21]

https://chromiumcodereview.appspot.com/1907263003/diff/20001/content/public/c...
File content/public/common/content_client.h (right):

https://chromiumcodereview.appspot.com/1907263003/diff/20001/content/public/c...
content/public/common/content_client.h:172: virtual media::MediaClientAndroid*
GetMediaClientAndroid();
Can this go into ContentGpuClient instead?

[xhwang, 2016-04-26 03:25:45]

https://chromiumcodereview.appspot.com/1907263003/diff/20001/content/public/c...
File content/public/common/content_client.h (right):

https://chromiumcodereview.appspot.com/1907263003/diff/20001/content/public/c...
content/public/common/content_client.h:172: virtual media::MediaClientAndroid*
GetMediaClientAndroid();
On 2016/04/26 00:02:21, Lei Zhang wrote:
> Can this go into ContentGpuClient instead?

Good question. Please see the CL description:

"Today in the browser, we call media::SetMediaClientAndroid() directly
from content embedders (e.g. ChromeBrowserMainPartsAndroid), which
seems hacky. We should use ContentClient::GetMediaClientAndroid() in
the browser process as well so that content will talk to the embedder,
and then talk to media. I'll work on it after this CL."

So this code will be called in both the browser process and gpu process.
Actually, in M53-ish we'll deprecate the browser part, at that point I should
be able to move this code to the GpuClient. Do you want me to do that
now and keep the browser code as is?

[Lei Zhang, 2016-04-26 04:27:49]

On 2016/04/26 03:25:45, xhwang wrote:
> So this code will be called in both the browser process and gpu process.

Whoops, missed that part.

> Actually, in M53-ish we'll deprecate the browser part, at that point I should
> be able to move this code to the GpuClient. Do you want me to do that
> now and keep the browser code as is?

Whatever is easier for you.

[xhwang, 2016-04-26 20:02:56]

On 2016/04/26 04:27:49, Lei Zhang wrote:
> On 2016/04/26 03:25:45, xhwang wrote:
> > So this code will be called in both the browser process and gpu process.
> 
> Whoops, missed that part.
> 
> > Actually, in M53-ish we'll deprecate the browser part, at that point I
should
> > be able to move this code to the GpuClient. Do you want me to do that
> > now and keep the browser code as is?
> 
> Whatever is easier for you.

Thought about this more. Today it's super easy to run the MediaDrm code in the
browser (just a gn arg change). So even after M53 where we deprecate the current
browser side code, I'd like to keep the ability to run MediaDrm in any process
for testing or for future development. So at this moment I'd like to keep this
CL as is.

PTAL

[Lei Zhang, 2016-04-26 20:47:59]

lgtm

[xhwang, 2016-04-28 00:24:19]

rebase only

[xhwang, 2016-04-28 20:11:15]

Patchset #5 (id:80001) has been deleted

[xhwang, 2016-04-28 21:21:37]

Description was changed from

==========
media: Set MediaClientAndroid in the GPU process.

Now on Android we use MediaDrmBridge in the GPU process. We should set
MediaClientAndroid the same as we do in the Browser process.

Summary of changes:
- Add ContentClient::GetMediaClientAndroid() API.
- SetMediaClientAndroid() in GPU process.

Today in the browser, we call media::SetMediaClientAndroid() directly
from content embedders (e.g. ChromeBrowserMainPartsAndroid), which
seems hacky. We should use ContentClient::GetMediaClientAndroid() in
the browser process as well so that content will talk to the embedder,
and then talk to media. I'll work on it after this CL.

BUG=605330
TEST=Encrypted Widevine contents plays in the GPU process on Android K.
==========

to

==========
media: Set MediaClientAndroid in the GPU process.

Now on Android we use MediaDrmBridge in the GPU process. We should set
MediaClientAndroid the same as we do in the Browser process.

Summary of changes:
- Add ContentClient::GetMediaClientAndroid() API.
- SetMediaClientAndroid() in GPU process.

Today in the browser, we call media::SetMediaClientAndroid() directly
from content embedders (e.g. ChromeBrowserMainPartsAndroid), which
seems hacky. We should use ContentClient::GetMediaClientAndroid() in
the browser process as well so that content will talk to the embedder,
and then talk to media. I'll work on it after this CL.

TBR=slan@chromium.org
BUG=605330
TEST=Encrypted Widevine contents plays in the GPU process on Android K.
==========

[xhwang, 2016-04-28 21:22:12]

TBRing slan on trivial chromecast changes.

[xhwang, 2016-04-28 21:22:22]

The CQ bit was checked by xhwang@chromium.org

[xhwang, 2016-04-28 21:22:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
thestig@chromium.org, boliu@chromium.org, nasko@chromium.org
Link to the patchset:
https://chromiumcodereview.appspot.com/1907263003/#ps100001 (title: " ")

[commit-bot: I haz the power, 2016-04-28 21:22:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1907263003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1907263003/100001

[commit-bot: I haz the power, 2016-04-28 22:13:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-28 22:13:48]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_TIMED_OUT,
no build URL)

[xhwang, 2016-04-28 22:23:16]

The CQ bit was checked by xhwang@chromium.org

[commit-bot: I haz the power, 2016-04-28 22:23:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1907263003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1907263003/100001

[commit-bot: I haz the power, 2016-04-28 22:44:30]

Description was changed from

==========
media: Set MediaClientAndroid in the GPU process.

Now on Android we use MediaDrmBridge in the GPU process. We should set
MediaClientAndroid the same as we do in the Browser process.

Summary of changes:
- Add ContentClient::GetMediaClientAndroid() API.
- SetMediaClientAndroid() in GPU process.

Today in the browser, we call media::SetMediaClientAndroid() directly
from content embedders (e.g. ChromeBrowserMainPartsAndroid), which
seems hacky. We should use ContentClient::GetMediaClientAndroid() in
the browser process as well so that content will talk to the embedder,
and then talk to media. I'll work on it after this CL.

TBR=slan@chromium.org
BUG=605330
TEST=Encrypted Widevine contents plays in the GPU process on Android K.
==========

to

==========
media: Set MediaClientAndroid in the GPU process.

Now on Android we use MediaDrmBridge in the GPU process. We should set
MediaClientAndroid the same as we do in the Browser process.

Summary of changes:
- Add ContentClient::GetMediaClientAndroid() API.
- SetMediaClientAndroid() in GPU process.

Today in the browser, we call media::SetMediaClientAndroid() directly
from content embedders (e.g. ChromeBrowserMainPartsAndroid), which
seems hacky. We should use ContentClient::GetMediaClientAndroid() in
the browser process as well so that content will talk to the embedder,
and then talk to media. I'll work on it after this CL.

TBR=slan@chromium.org
BUG=605330
TEST=Encrypted Widevine contents plays in the GPU process on Android K.
==========

[commit-bot: I haz the power, 2016-04-28 22:44:31]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-04-30 17:22:18]

Patchset 5 (id:??) landed as
https://crrev.com/f258baab74abe43f7f77bdae8b74c61c07f95f51
Cr-Commit-Position: refs/heads/master@{#390517}

[commit-bot: I haz the power, 2016-04-30 17:58:07]

Description was changed from

==========
media: Set MediaClientAndroid in the GPU process.

Now on Android we use MediaDrmBridge in the GPU process. We should set
MediaClientAndroid the same as we do in the Browser process.

Summary of changes:
- Add ContentClient::GetMediaClientAndroid() API.
- SetMediaClientAndroid() in GPU process.

Today in the browser, we call media::SetMediaClientAndroid() directly
from content embedders (e.g. ChromeBrowserMainPartsAndroid), which
seems hacky. We should use ContentClient::GetMediaClientAndroid() in
the browser process as well so that content will talk to the embedder,
and then talk to media. I'll work on it after this CL.

TBR=slan@chromium.org
BUG=605330
TEST=Encrypted Widevine contents plays in the GPU process on Android K.
==========

to

==========
media: Set MediaClientAndroid in the GPU process.

Now on Android we use MediaDrmBridge in the GPU process. We should set
MediaClientAndroid the same as we do in the Browser process.

Summary of changes:
- Add ContentClient::GetMediaClientAndroid() API.
- SetMediaClientAndroid() in GPU process.

Today in the browser, we call media::SetMediaClientAndroid() directly
from content embedders (e.g. ChromeBrowserMainPartsAndroid), which
seems hacky. We should use ContentClient::GetMediaClientAndroid() in
the browser process as well so that content will talk to the embedder,
and then talk to media. I'll work on it after this CL.

TBR=slan@chromium.org
BUG=605330
TEST=Encrypted Widevine contents plays in the GPU process on Android K.

Committed: https://crrev.com/f258baab74abe43f7f77bdae8b74c61c07f95f51
Cr-Commit-Position: refs/heads/master@{#390517}
==========