Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 2063053002: Subzero: x86-64: Allow immediates in 64-bit instructions. (Closed)

Created:
4 years, 6 months ago by Jim Stichnoth
Modified:
4 years, 6 months ago
Reviewers:
Eric Holk, Karl, John, manasijm
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: x86-64: Allow immediates in 64-bit instructions. The original code legalized *all* i64 constants into a register move, creating unnecessary instructions and slightly higher register pressure in most cases. Generally, immediates can be used in 64-bit instructions as long as the immediate can be represented as a sign-extended 32-bit value. BUG= none R=jpp@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=9c2c093f37106ab952a439fa098d862101bb5854

Patch Set 1 #

Patch Set 2 : Fix assert. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -10 lines) Patch
M src/IceAssemblerX86BaseImpl.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M src/IceInstX86BaseImpl.h View 4 chunks +14 lines, -1 line 0 comments Download
M src/IceTargetLoweringX86BaseImpl.h View 2 chunks +12 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Jim Stichnoth
This doesn't really help spec2k performance, but the code does look slightly better.
4 years, 6 months ago (2016-06-14 14:08:14 UTC) #3
John
lgtm
4 years, 6 months ago (2016-06-14 14:21:35 UTC) #4
Jim Stichnoth
4 years, 6 months ago (2016-06-14 14:27:29 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
9c2c093f37106ab952a439fa098d862101bb5854 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698