Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Issue 2062963003: Add a flag to disable server experiments in DRP (Closed)

Created:
4 years, 6 months ago by tbansal1
Modified:
4 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a flag to disable server experiments in DRP Use this flag to disable server experiments field trial when running Lo-Fi integration tests. BUG=619622 Committed: https://crrev.com/c55229da0bb74bc1a1abee81fd248fe1843448d1 Cr-Commit-Position: refs/heads/master@{#399592}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix the test #

Patch Set 3 : kundaji comments #

Messages

Total messages: 24 (16 generated)
tbansal1
PTAL. Thanks.
4 years, 6 months ago (2016-06-13 21:13:41 UTC) #13
bustamante
On 2016/06/13 21:13:41, tbansal1 wrote: > PTAL. Thanks. lgtm For changes to tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py
4 years, 6 months ago (2016-06-13 21:18:59 UTC) #14
Not at Google. Contact bengr
lgtm https://codereview.chromium.org/2062963003/diff/160001/components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc File components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc (right): https://codereview.chromium.org/2062963003/diff/160001/components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc#newcode126 components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc:126: const std::string lo_fi_value = Keep reference with '&'?
4 years, 6 months ago (2016-06-13 21:50:45 UTC) #15
tbansal1
https://codereview.chromium.org/2062963003/diff/160001/components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc File components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc (right): https://codereview.chromium.org/2062963003/diff/160001/components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc#newcode126 components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc:126: const std::string lo_fi_value = On 2016/06/13 21:50:45, kundaji wrote: ...
4 years, 6 months ago (2016-06-13 22:00:07 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2062963003/200001
4 years, 6 months ago (2016-06-13 22:04:27 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:200001)
4 years, 6 months ago (2016-06-13 23:04:38 UTC) #21
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-13 23:04:50 UTC) #22
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 23:06:40 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c55229da0bb74bc1a1abee81fd248fe1843448d1
Cr-Commit-Position: refs/heads/master@{#399592}

Powered by Google App Engine
This is Rietveld 408576698