Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(912)

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options_unittest.cc

Issue 2062963003: Add a flag to disable server experiments in DRP (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: kundaji comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options_unittest.cc
diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options_unittest.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options_unittest.cc
index 5a99478bd07cc88b482156b752ec407c4e304471..32cb51db7b0fd92a1472006e03ea33facd7a93c7 100644
--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options_unittest.cc
+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options_unittest.cc
@@ -261,17 +261,22 @@ TEST_F(DataReductionProxyRequestOptionsTest, ParseExperimentsFromFieldTrial) {
const struct {
std::string field_trial_group;
std::string command_line_experiment;
+ bool disable_server_experiments_via_flag;
std::string expected_experiment;
} tests[] = {
// Disabled field trial groups.
- {"disabled_group", std::string(), std::string()},
- {"disabled_group", kExperimentFoo, kExperimentFoo},
+ {"disabled_group", std::string(), false, std::string()},
+ {"disabled_group", kExperimentFoo, false, kExperimentFoo},
// Valid field trial groups should pick from field trial.
- {kFieldTrialGroupFoo, std::string(), kExperimentFoo},
- {kFieldTrialGroupBar, std::string(), kExperimentBar},
+ {kFieldTrialGroupFoo, std::string(), false, kExperimentFoo},
+ {kFieldTrialGroupBar, std::string(), false, kExperimentBar},
+ {kFieldTrialGroupFoo, std::string(), true, std::string()},
+ {kFieldTrialGroupBar, std::string(), true, std::string()},
// Experiments from command line switch should override.
- {kFieldTrialGroupFoo, kExperimentBar, kExperimentBar},
- {kFieldTrialGroupBar, kExperimentFoo, kExperimentFoo},
+ {kFieldTrialGroupFoo, kExperimentBar, false, kExperimentBar},
+ {kFieldTrialGroupBar, kExperimentFoo, false, kExperimentFoo},
+ {kFieldTrialGroupFoo, kExperimentBar, true, kExperimentBar},
+ {kFieldTrialGroupBar, kExperimentFoo, true, kExperimentFoo},
};
std::map<std::string, std::string> server_experiment_foo,
@@ -289,9 +294,15 @@ TEST_F(DataReductionProxyRequestOptionsTest, ParseExperimentsFromFieldTrial) {
for (const auto& test : tests) {
std::vector<std::string> expected_experiments;
+ base::CommandLine::ForCurrentProcess()->InitFromArgv(0, NULL);
+
base::CommandLine::ForCurrentProcess()->AppendSwitchASCII(
data_reduction_proxy::switches::kDataReductionProxyExperiment,
test.command_line_experiment);
+ if (test.disable_server_experiments_via_flag) {
+ base::CommandLine::ForCurrentProcess()->AppendSwitchASCII(
+ switches::kDataReductionProxyServerExperimentsDisabled, "");
+ }
std::string expected_header;
base::FieldTrialList field_trial_list(nullptr);

Powered by Google App Engine
This is Rietveld 408576698