Clean up two unlaunched SSE 4.1 8888 blits.

Clean up two unlaunched SSE 4.1 8888 blits.

This code was running on our bots but never in Chrome.
That's a bad state to be in.

My plan here use to be to redesign how our 8888 blits worked in SSE 4.1, mainly
for perfect correctness but also for speed, then to spread what I learned there
to SSE2, AVX+, and NEON.

I have since lost interest in changing any aspect of how our legacy 8888 blits
work.  There's not much point in making them a bit or two more correct when the
math is fundamentally wrong.

This will cause many diffs in Gold, none perceptible.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2062853002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

Committed: https://skia.googlesource.com/skia/+/6e472093009bf2fc4a8e53010b51040efcb71213
Committed: https://skia.googlesource.com/skia/+/c2a7c2fe89650e90199b9c41a4a9c0bec3d523a2

[mtklein_C, 2016-06-13 15:35:30]

Description was changed from

==========
Clean up two unlaunched SSE 4.1 8888 blits.

This code was running on our bots but never in Chrome.
That's a bad state to be in.

My plan here use to be to redesign how our 8888 blits worked in SSE 4.1, mainly
for perfect correctness but also for speed, then to spread what I learned there
to SSE2, AVX+, and NEON.

I have since lost interest in changing any aspect of how our legacy 8888 blits
work.  There's not much point in making them a bit or two more correct when the
math is fundamentally wrong.

This will cause many diffs in Gold, none perceptible.

BUG=skia:
==========

to

==========
Clean up two unlaunched SSE 4.1 8888 blits.

This code was running on our bots but never in Chrome.
That's a bad state to be in.

My plan here use to be to redesign how our 8888 blits worked in SSE 4.1, mainly
for perfect correctness but also for speed, then to spread what I learned there
to SSE2, AVX+, and NEON.

I have since lost interest in changing any aspect of how our legacy 8888 blits
work.  There's not much point in making them a bit or two more correct when the
math is fundamentally wrong.

This will cause many diffs in Gold, none perceptible.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2062853002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

[mtklein_C, 2016-06-13 15:36:10]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-13 15:36:19]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2062853002/1

[commit-bot: I haz the power, 2016-06-13 15:47:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-13 15:47:49]

Dry run: This issue passed the CQ dry run.

[mtklein_C, 2016-06-13 15:54:58]

mtklein@chromium.org changed reviewers:
+ reed@google.com

[reed1, 2016-06-13 17:23:44]

lgtm

[mtklein_C, 2016-06-13 17:47:00]

The CQ bit was checked by mtklein@chromium.org

[commit-bot: I haz the power, 2016-06-13 17:47:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2062853002/1

[commit-bot: I haz the power, 2016-06-13 17:48:08]

Description was changed from

==========
Clean up two unlaunched SSE 4.1 8888 blits.

This code was running on our bots but never in Chrome.
That's a bad state to be in.

My plan here use to be to redesign how our 8888 blits worked in SSE 4.1, mainly
for perfect correctness but also for speed, then to spread what I learned there
to SSE2, AVX+, and NEON.

I have since lost interest in changing any aspect of how our legacy 8888 blits
work.  There's not much point in making them a bit or two more correct when the
math is fundamentally wrong.

This will cause many diffs in Gold, none perceptible.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2062853002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

to

==========
Clean up two unlaunched SSE 4.1 8888 blits.

This code was running on our bots but never in Chrome.
That's a bad state to be in.

My plan here use to be to redesign how our 8888 blits worked in SSE 4.1, mainly
for perfect correctness but also for speed, then to spread what I learned there
to SSE2, AVX+, and NEON.

I have since lost interest in changing any aspect of how our legacy 8888 blits
work.  There's not much point in making them a bit or two more correct when the
math is fundamentally wrong.

This will cause many diffs in Gold, none perceptible.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2062853002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

Committed:
https://skia.googlesource.com/skia/+/6e472093009bf2fc4a8e53010b51040efcb71213
==========

[commit-bot: I haz the power, 2016-06-13 17:48:09]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/6e472093009bf2fc4a8e53010b51040efcb71213

[mtklein_C, 2016-06-13 18:55:49]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2066453003/ by mtklein@chromium.org.

The reason for reverting is: Breaks a couple Google3 goldens.  I need to
rebaseline google3 with -DSK_SUPPORT_LEGACY_X86_BLITS first, then reland this..

[mtklein, 2016-06-16 18:53:26]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2016-06-16 18:53:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2062853002/1

[commit-bot: I haz the power, 2016-06-16 19:11:54]

Description was changed from

==========
Clean up two unlaunched SSE 4.1 8888 blits.

This code was running on our bots but never in Chrome.
That's a bad state to be in.

My plan here use to be to redesign how our 8888 blits worked in SSE 4.1, mainly
for perfect correctness but also for speed, then to spread what I learned there
to SSE2, AVX+, and NEON.

I have since lost interest in changing any aspect of how our legacy 8888 blits
work.  There's not much point in making them a bit or two more correct when the
math is fundamentally wrong.

This will cause many diffs in Gold, none perceptible.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2062853002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

Committed:
https://skia.googlesource.com/skia/+/6e472093009bf2fc4a8e53010b51040efcb71213
==========

to

==========
Clean up two unlaunched SSE 4.1 8888 blits.

This code was running on our bots but never in Chrome.
That's a bad state to be in.

My plan here use to be to redesign how our 8888 blits worked in SSE 4.1, mainly
for perfect correctness but also for speed, then to spread what I learned there
to SSE2, AVX+, and NEON.

I have since lost interest in changing any aspect of how our legacy 8888 blits
work.  There's not much point in making them a bit or two more correct when the
math is fundamentally wrong.

This will cause many diffs in Gold, none perceptible.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2062853002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

Committed:
https://skia.googlesource.com/skia/+/6e472093009bf2fc4a8e53010b51040efcb71213
Committed:
https://skia.googlesource.com/skia/+/c2a7c2fe89650e90199b9c41a4a9c0bec3d523a2
==========

[commit-bot: I haz the power, 2016-06-16 19:11:55]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c2a7c2fe89650e90199b9c41a4a9c0bec3d523a2