Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2062813002: Remove some scripts that were used by the valgrind bots. (Closed)

Created:
4 years, 6 months ago by Nico
Modified:
3 years, 6 months ago
Reviewers:
Lei Zhang, Dirk Pranke
CC:
chromium-reviews, glider+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove some scripts that were used by the valgrind bots. BUG=605605 Review-Url: https://codereview.chromium.org/2062813002 Cr-Commit-Position: refs/heads/master@{#480183} Committed: https://chromium.googlesource.com/chromium/src/+/ea265234ce5127525b22b733bb3bc39c0c7ee5e2

Patch Set 1 #

Patch Set 2 : rebsae #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2129 lines) Patch
D testing/scripts/run_under_valgrind.py View 1 chunk +0 lines, -38 lines 0 comments Download
D tools/valgrind/chrome_tests.bat View 1 1 chunk +0 lines, -53 lines 0 comments Download
D tools/valgrind/chrome_tests.py View 1 1 chunk +0 lines, -863 lines 0 comments Download
D tools/valgrind/chrome_tests.sh View 1 chunk +0 lines, -90 lines 0 comments Download
D tools/valgrind/locate_valgrind.sh View 1 1 chunk +0 lines, -69 lines 0 comments Download
D tools/valgrind/valgrind.gni View 1 1 chunk +0 lines, -64 lines 0 comments Download
D tools/valgrind/valgrind.sh View 1 chunk +0 lines, -106 lines 0 comments Download
D tools/valgrind/valgrind_test.py View 1 1 chunk +0 lines, -846 lines 0 comments Download

Messages

Total messages: 29 (16 generated)
Nico
Do you know if we still use tools/valgrind/memcheck/suppressions.txt? I would've thought no, but it's still ...
4 years, 6 months ago (2016-06-13 14:50:47 UTC) #2
Lei Zhang
I'm still using the scripts to run Valgrind locally as I close out bugs. Though ...
4 years, 6 months ago (2016-06-13 17:52:00 UTC) #3
Nico
sure, let's do nothing here for a while.
4 years, 6 months ago (2016-06-13 18:08:22 UTC) #4
Nico
So, should we land this now?
3 years, 6 months ago (2017-06-15 17:57:16 UTC) #5
Lei Zhang
Sure. It's been a while. Does the CL need a rebase?
3 years, 6 months ago (2017-06-15 18:00:37 UTC) #8
Nico
rebased. dpranke did the docs/ changes in the meantime, so i deleted a bunch more ...
3 years, 6 months ago (2017-06-15 19:30:24 UTC) #11
Lei Zhang
lgtm
3 years, 6 months ago (2017-06-16 17:32:36 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2062813002/20001
3 years, 6 months ago (2017-06-16 19:54:41 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/466366)
3 years, 6 months ago (2017-06-16 20:06:25 UTC) #20
Nico
+dpranke for testing/OWNERS
3 years, 6 months ago (2017-06-16 20:08:15 UTC) #22
Dirk Pranke
lgtm
3 years, 6 months ago (2017-06-16 20:30:19 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2062813002/20001
3 years, 6 months ago (2017-06-16 20:30:52 UTC) #25
commit-bot: I haz the power
3 years, 6 months ago (2017-06-16 21:37:20 UTC) #29
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ea265234ce5127525b22b733bb3b...

Powered by Google App Engine
This is Rietveld 408576698