Bin circular blur profile textures by scale and blur to radius ratio

Bin circular blur profile textures by scale and blur to radius ratio.

This reduces the number of profile textures that will be generated throughout an animation and also caps the texture size. It could probably be better tuned.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2062743003

Committed: https://skia.googlesource.com/skia/+/f7fcdb226dc1a2d2929ef26c5ce7cea4460b809c

[bsalomon, 2016-06-13 18:46:30]

Description was changed from

==========
Bin circular blur profile textures by scale and blur to radius ratio
==========

to

==========
Bin circular blur profile textures by scale and blur to radius ratio
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2062743003
==========

[bsalomon, 2016-06-13 18:55:43]

Description was changed from

==========
Bin circular blur profile textures by scale and blur to radius ratio
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2062743003
==========

to

==========
Bin circular blur profile textures by scale and blur to radius ratio.

This reduces the number of profile textures that will be generated throughout an
animation and also caps the texture size. It could probably be better tuned.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2062743003
==========

[bsalomon, 2016-06-13 18:55:43]

bsalomon@google.com changed reviewers:
+ jvanverth@google.com

[jvanverth1, 2016-06-14 18:51:15]

Just a few questions/comments.

https://codereview.chromium.org/2062743003/diff/20001/src/effects/GrCircleBlu...
File src/effects/GrCircleBlurFragmentProcessor.cpp (right):

https://codereview.chromium.org/2062743003/diff/20001/src/effects/GrCircleBlu...
src/effects/GrCircleBlurFragmentProcessor.cpp:110: return;
Won't this return garbage (whatever was there before) in b?

https://codereview.chromium.org/2062743003/diff/20001/src/effects/GrCircleBlu...
src/effects/GrCircleBlurFragmentProcessor.cpp:207: //   
compute_profile_offset_and_size(circleR, sigma, &offset, &numSteps);
Delete this line?

https://codereview.chromium.org/2062743003/diff/20001/src/effects/GrCircleBlu...
File src/effects/GrCircleBlurFragmentProcessor.h (right):

https://codereview.chromium.org/2062743003/diff/20001/src/effects/GrCircleBlu...
src/effects/GrCircleBlurFragmentProcessor.h:82: class GLSLProcessor;
This forward declaration is little confusing (it looks like it doesn't belong
here). Maybe a comment?

[bsalomon, 2016-06-14 19:16:52]

https://codereview.chromium.org/2062743003/diff/20001/src/effects/GrCircleBlu...
File src/effects/GrCircleBlurFragmentProcessor.cpp (right):

https://codereview.chromium.org/2062743003/diff/20001/src/effects/GrCircleBlu...
src/effects/GrCircleBlurFragmentProcessor.cpp:110: return;
On 2016/06/14 18:51:15, jvanverth1 wrote:
> Won't this return garbage (whatever was there before) in b?

This just leaves the key empty (since this processor always generates the same
code). I added a comment.

https://codereview.chromium.org/2062743003/diff/20001/src/effects/GrCircleBlu...
src/effects/GrCircleBlurFragmentProcessor.cpp:207: //   
compute_profile_offset_and_size(circleR, sigma, &offset, &numSteps);
On 2016/06/14 18:51:15, jvanverth1 wrote:
> Delete this line?

oops, done.

https://codereview.chromium.org/2062743003/diff/20001/src/effects/GrCircleBlu...
File src/effects/GrCircleBlurFragmentProcessor.h (right):

https://codereview.chromium.org/2062743003/diff/20001/src/effects/GrCircleBlu...
src/effects/GrCircleBlurFragmentProcessor.h:82: class GLSLProcessor;
On 2016/06/14 18:51:15, jvanverth1 wrote:
> This forward declaration is little confusing (it looks like it doesn't belong
> here). Maybe a comment?

Done.

[bsalomon, 2016-06-14 19:17:30]

The CQ bit was checked by bsalomon@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-14 19:17:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2062743003/40001

[commit-bot: I haz the power, 2016-06-14 19:23:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-14 19:23:33]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[bsalomon, 2016-06-14 19:55:09]

The CQ bit was checked by bsalomon@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-14 19:55:15]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2062743003/60001

[commit-bot: I haz the power, 2016-06-14 20:08:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-14 20:08:01]

Dry run: This issue passed the CQ dry run.

[jvanverth1, 2016-06-14 20:27:15]

lgtm

[bsalomon, 2016-06-14 21:08:51]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2016-06-14 21:08:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2062743003/60001

[commit-bot: I haz the power, 2016-06-14 21:37:17]

Description was changed from

==========
Bin circular blur profile textures by scale and blur to radius ratio.

This reduces the number of profile textures that will be generated throughout an
animation and also caps the texture size. It could probably be better tuned.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2062743003
==========

to

==========
Bin circular blur profile textures by scale and blur to radius ratio.

This reduces the number of profile textures that will be generated throughout an
animation and also caps the texture size. It could probably be better tuned.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2062743003

Committed:
https://skia.googlesource.com/skia/+/f7fcdb226dc1a2d2929ef26c5ce7cea4460b809c
==========

[commit-bot: I haz the power, 2016-06-14 21:37:19]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/f7fcdb226dc1a2d2929ef26c5ce7cea4460b809c