Issue 206273002: Fix the assembly file for Mac

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 206273002: Fix the assembly file for Mac (Closed)

Created:
6 years, 9 months ago by jungshik at Google

Modified:
6 years, 9 months ago

Reviewers:
Mark Mentovai, Torne

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/deps/third_party/icu46/

Visibility:
Public.

More Reviews

Description

Fix the assembly file for Mac icu_use_data_file_flag is the default so that this file is not used unless icu_use_data_file_flag is set to 0. Just in case, I'm fixing this file. A fix is a one liner (one character long). '_' was missing in the previous check-in. @@ -5,7 +5,7 @@ .data .const .align 4 -icudt46_dat: +_icudt46_dat: R=mark@chromium.org, torne@chromium.org TBR=mark@chromium.org BUG=NONE TEST=With icu_use_data_file_flag=0 in GYPDEFINES, Mac build succeeds. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258359

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	mac/icudt46l_dat.S	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jungshik at Google

6 years, 9 months ago (2014-03-20 18:30:45 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r258359 (presubmit successful).

Expand Messages | Collapse Messages