Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(103)

Issue 206273002: Fix the assembly file for Mac (Closed)

Created:
5 years, 9 months ago by jungshik at Google
Modified:
5 years, 9 months ago
Reviewers:
Mark Mentovai, Torne
CC:
chromium-reviews
Visibility:
Public.

Description

Fix the assembly file for Mac icu_use_data_file_flag is the default so that this file is not used unless icu_use_data_file_flag is set to 0. Just in case, I'm fixing this file. A fix is a one liner (one character long). '_' was missing in the previous check-in. @@ -5,7 +5,7 @@ .data .const .align 4 -icudt46_dat: +_icudt46_dat: R=mark@chromium.org, torne@chromium.org TBR=mark@chromium.org BUG=NONE TEST=With icu_use_data_file_flag=0 in GYPDEFINES, Mac build succeeds. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258359

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M mac/icudt46l_dat.S View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Torne
lgtm
5 years, 9 months ago (2014-03-20 18:23:53 UTC) #1
Mark Mentovai
LGTM
5 years, 9 months ago (2014-03-20 18:25:16 UTC) #2
jungshik at Google
5 years, 9 months ago (2014-03-20 18:30:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r258359 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698