Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2062533002:
Disable incremental invalidation for SVG (Closed)
|
Created:
4 years, 6 months ago by pdr. Modified:
4 years, 6 months ago CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, f(malita), fs, gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1 Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDisable incremental invalidation for SVG
Incremental invalidation is a feature where size changes (e.g.,
shrinking an object's height) can only invalidate the shrunken region
instead of the entire object. This can lead to underinvalidation bugs
if the object is not fully opaque, such as the case of rounded corners.
This patch switches all incremental invalidations to be full
invalidations.
BUG=619108
Committed: https://crrev.com/6c46c2c4123213eb9a684a1df9ec22cccea39d52
Cr-Commit-Position: refs/heads/master@{#399384}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Address reviewer comments and make final #Patch Set 3 : Rebase #
Messages
Total messages: 28 (13 generated)
Description was changed from ========== Disable incremental invalidation for SVG Incremental invalidation is a feature where size changes (e.g., shrinking an object's height) can only invalidate the shrunk region instead of the entire object. This can lead to underinvalidation bugs if the object is not fully opaque, such as the case of rounded corners. This patch switches all incremental invalidations to be full invalidations. BUG=619108 ========== to ========== Disable incremental invalidation for SVG Incremental invalidation is a feature where size changes (e.g., shrinking an object's height) can only invalidate the shrunken region instead of the entire object. This can lead to underinvalidation bugs if the object is not fully opaque, such as the case of rounded corners. This patch switches all incremental invalidations to be full invalidations. BUG=619108 ==========
pdr@chromium.org changed reviewers: + chrishtr@chromium.org, wangxianzhu@chromium.org
The CQ bit was checked by pdr@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2062533002/1
lgtm https://codereview.chromium.org/2062533002/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/layout/svg/LayoutSVGModelObject.h (right): https://codereview.chromium.org/2062533002/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/layout/svg/LayoutSVGModelObject.h:73: const LayoutRect& newBounds, const LayoutPoint& newPositionFromPaintInvalidationContainer) const override; Nit: I think you can use the shorter version of the parameter names as in the implementation (or omit them).
On 2016/06/10 at 23:03:27, wangxianzhu wrote: > lgtm > > https://codereview.chromium.org/2062533002/diff/1/third_party/WebKit/Source/c... > File third_party/WebKit/Source/core/layout/svg/LayoutSVGModelObject.h (right): > > https://codereview.chromium.org/2062533002/diff/1/third_party/WebKit/Source/c... > third_party/WebKit/Source/core/layout/svg/LayoutSVGModelObject.h:73: const LayoutRect& newBounds, const LayoutPoint& newPositionFromPaintInvalidationContainer) const override; > Nit: I think you can use the shorter version of the parameter names as in the implementation (or omit them). Done! Also changed to final.
lgtm
The CQ bit was checked by pdr@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from wangxianzhu@chromium.org Link to the patchset: https://codereview.chromium.org/2062533002/#ps20001 (title: "Address reviewer comments and make final")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2062533002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by pdr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2062533002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by pdr@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from chrishtr@chromium.org, wangxianzhu@chromium.org Link to the patchset: https://codereview.chromium.org/2062533002/#ps40001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2062533002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by pdr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2062533002/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
CQ bit was unchecked
Message was sent while issue was closed.
Description was changed from ========== Disable incremental invalidation for SVG Incremental invalidation is a feature where size changes (e.g., shrinking an object's height) can only invalidate the shrunken region instead of the entire object. This can lead to underinvalidation bugs if the object is not fully opaque, such as the case of rounded corners. This patch switches all incremental invalidations to be full invalidations. BUG=619108 ========== to ========== Disable incremental invalidation for SVG Incremental invalidation is a feature where size changes (e.g., shrinking an object's height) can only invalidate the shrunken region instead of the entire object. This can lead to underinvalidation bugs if the object is not fully opaque, such as the case of rounded corners. This patch switches all incremental invalidations to be full invalidations. BUG=619108 Committed: https://crrev.com/6c46c2c4123213eb9a684a1df9ec22cccea39d52 Cr-Commit-Position: refs/heads/master@{#399384} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/6c46c2c4123213eb9a684a1df9ec22cccea39d52 Cr-Commit-Position: refs/heads/master@{#399384} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
