third_party/WebKit/Source/core/layout/svg/LayoutSVGModelObject.h - Issue 2062533002: Disable incremental invalidation for SVG

Side by Side Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGModelObject.h

Issue 2062533002: Disable incremental invalidation for SVG (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (c) 2009, Google Inc. All rights reserved.	2 * Copyright (c) 2009, Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 50 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
61 void computeLayerHitTestRects(LayerHitTestRects&) const final;	61 void computeLayerHitTestRects(LayerHitTestRects&) const final;

62	62

63 SVGElement* element() const { return toSVGElement(LayoutObject::node()); }	63 SVGElement* element() const { return toSVGElement(LayoutObject::node()); }

64	64

65 bool isOfType(LayoutObjectType type) const override { return type == LayoutO bjectSVG \|\| LayoutObject::isOfType(type); }	65 bool isOfType(LayoutObjectType type) const override { return type == LayoutO bjectSVG \|\| LayoutObject::isOfType(type); }

66	66

67 protected:	67 protected:

68 void addLayerHitTestRects(LayerHitTestRects&, const PaintLayer* currentCompo sitedLayer, const LayoutPoint& layerOffset, const LayoutRect& containerRect) con st final;	68 void addLayerHitTestRects(LayerHitTestRects&, const PaintLayer* currentCompo sitedLayer, const LayoutPoint& layerOffset, const LayoutRect& containerRect) con st final;

69 void willBeDestroyed() override;	69 void willBeDestroyed() override;

70	70

	71 PaintInvalidationReason getPaintInvalidationReason(const PaintInvalidationSt ate&,

	72 const LayoutRect& oldBounds, const LayoutPoint& oldPositionFromPaintInva lidationContainer,

	73 const LayoutRect& newBounds, const LayoutPoint& newPositionFromPaintInva lidationContainer) const override;
	Xianzhu 2016/06/10 23:03:27 Nit: I think you can use the shorter version of th Nit: I think you can use the shorter version of the parameter names as in the implementation (or omit them).
71 private:	74 private:

72 // LayoutSVGModelObject subclasses should use element() instead.	75 // LayoutSVGModelObject subclasses should use element() instead.

73 void node() const = delete;	76 void node() const = delete;

74	77

75 // This method should never be called, SVG uses a different nodeAtPoint meth od	78 // This method should never be called, SVG uses a different nodeAtPoint meth od

76 bool nodeAtPoint(HitTestResult&, const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset, HitTestAction) final;	79 bool nodeAtPoint(HitTestResult&, const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset, HitTestAction) final;

77 IntRect absoluteElementBoundingBoxRect() const final;	80 IntRect absoluteElementBoundingBoxRect() const final;

78	81

79 protected:	82 protected:

80 FloatRect m_paintInvalidationBoundingBox;	83 FloatRect m_paintInvalidationBoundingBox;

81 };	84 };

82	85

83 } // namespace blink	86 } // namespace blink

84	87

85 #endif	88 #endif

OLD	NEW